From: "Linus Lüssing" <linus.luessing@web.de>
To: Jan Beulich <JBeulich@novell.com>
Cc: <davem@davemloft.net>, <shemminger@linux-foundation.org>,
<bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>
Subject: Re: build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()
Date: Tue, 22 Mar 2011 22:40:31 +0100 [thread overview]
Message-ID: <1300830032-6727-1-git-send-email-linus.luessing@web.de> (raw)
In-Reply-To: <4D80BC5B0200007800036D85@vpn.id2.novell.com>
> One unrelated other observation with this change of yours:
> daddr is an input argument to ipv6_dev_get_saddr(), yet
> it gets initialized only after the function was called. Is that
> really correct?
Hmm, that wasn't intentional. I tested that again and so far I still always
got the right source address. I had a little deeper look at ipv6_dev_get_saddr()
and seems like it could get racy the way it is now, so I'm attaching a patch
for that. Thanks for reporting, Jan.
And I hope I didn't cause too much inconvience with the build breakage,
didn't think of testing BRIDGE=y and IPV6=m.
Cheers, Linus
next prev parent reply other threads:[~2011-03-22 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 12:34 build breakage due to br_multicast.c referencing ipv6_dev_get_saddr() Jan Beulich
2011-03-16 15:24 ` Stephen Hemminger
2011-03-16 17:49 ` David Miller
2011-03-17 7:53 ` Jan Beulich
2011-03-17 8:01 ` Jan Beulich
2011-03-17 8:23 ` Eric Dumazet
2011-03-17 13:00 ` David Miller
2011-03-16 16:41 ` Stephen Hemminger
2011-03-16 17:34 ` Brian Haley
2011-03-17 7:57 ` Jan Beulich
2011-03-17 13:45 ` Brian Haley
2011-03-16 17:49 ` David Miller
2011-03-22 21:40 ` Linus Lüssing [this message]
2011-03-22 21:40 ` [PATCH] bridge: Fix possibly wrong MLD queries' ethernet source address Linus Lüssing
2011-03-23 2:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300830032-6727-1-git-send-email-linus.luessing@web.de \
--to=linus.luessing@web.de \
--cc=JBeulich@novell.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).