From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Freyther Subject: [PATCH] sctp: Remove store to ret as it is not used Date: Wed, 23 Mar 2011 11:56:46 +0100 Message-ID: <1300877806-3949-1-git-send-email-zecke@selfish.org> Cc: linux-sctp@vger.kernel.org, Holger Hans Peter Freyther To: netdev@vger.kernel.org Return-path: Received: from gandharva.secretlabs.de ([78.46.147.237]:59303 "EHLO gandharva.secretlabs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932303Ab1CWLHN (ORCPT ); Wed, 23 Mar 2011 07:07:13 -0400 Sender: netdev-owner@vger.kernel.org List-ID: From: Holger Hans Peter Freyther The store to ret is not needed. In case it is 0 the method will be exited directly, if not ret will be assigned again and then returned to the caller. Signed-off-by: Holger Hans Peter Freyther Acked-by: Wei Yongjun --- net/sctp/socket.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index b2bed35..5f72996 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -393,9 +393,8 @@ SCTP_STATIC int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len) * detection. */ addr->v4.sin_port = htons(snum); - if ((ret = sctp_get_port_local(sk, addr))) { + if (sctp_get_port_local(sk, addr)) return -EADDRINUSE; - } /* Refresh ephemeral port. */ if (!bp->port) -- 1.7.4