From: Ben Hutchings <bhutchings@solarflare.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eugenia Emantayev <eugenia@mellanox.co.il>
Subject: RE: [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i
Date: Thu, 24 Mar 2011 03:40:19 +0000 [thread overview]
Message-ID: <1300938019.26693.528.camel@localhost> (raw)
In-Reply-To: <953B660C027164448AE903364AC447D20705BE28@mtldag01.mtl.com>
On Wed, 2011-03-23 at 15:10 +0000, Yevgeny Petrilin wrote:
> >
> > This is an abuse of the ethtool_drvinfo::driver field.
> >
> > Your users can use lspci -v, can't they?
> >
> I don't think there is a problem here.
> We have always reported the HW model via Ethtool, we just expanded the information
> we provide.
> Our users prefer to see the information in ethtool.
I can provide a patch for David if you won't.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-03-24 3:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 8:38 [PATCH v2 08/16] mlx4_en: Reporting HW revision in ethtool -i Yevgeny Petrilin
2011-03-23 14:04 ` Ben Hutchings
2011-03-23 15:10 ` Yevgeny Petrilin
2011-03-23 15:46 ` Ben Hutchings
2011-03-23 15:54 ` Yevgeny Petrilin
2011-03-23 16:08 ` Ben Hutchings
2011-03-23 17:06 ` Stephen Hemminger
2011-03-23 15:58 ` Stephen Hemminger
2011-03-23 19:36 ` David Miller
2011-03-24 3:40 ` Ben Hutchings [this message]
2011-03-24 6:26 ` Yevgeny Petrilin
2011-03-23 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300938019.26693.528.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).