From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: alessandro.suardi@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: fix fib metrics
Date: Thu, 24 Mar 2011 23:44:12 +0100 [thread overview]
Message-ID: <1301006652.2714.145.camel@edumazet-laptop> (raw)
In-Reply-To: <20110324.153623.45921344.davem@davemloft.net>
Le jeudi 24 mars 2011 à 15:36 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 24 Mar 2011 23:32:26 +0100
>
> > Then it doesnt work anymore because it parses an ipip field from
> > ip route get ...
> >
> > $ ip ro get 192.168.1.1
> > 192.168.1.1 dev wlan0 src 192.168.1.21
> > cache ipid 0x784c mtu 1500 advmss 1460 hoplimit 64
> >
> >
> > Maybe you upgraded iproute2
>
> I'm leaning towards app bug too.
>
> These default metrics wouldn't get printed before, but now because of
> how metrics are handled, they will.
>
> Userland needs to cope properly with this.
BTW, ipip is not always printed (even on old kernels) : One needs to
actually need ipip generation .
edumazet@edumazet-laptop:~$ ping 4.4.4.4
PING 4.4.4.4 (4.4.4.4) 56(84) bytes of data.
^C
edumazet@edumazet-laptop:~$ ip ro get 4.4.4.4
4.4.4.4 dev ppp0 src 10.150.51.210
cache mtu 1500 advmss 1460 hoplimit 64
edumazet@edumazet-laptop:~$ ping -s 2000 4.4.4.4
PING 4.4.4.4 (4.4.4.4) 2000(2028) bytes of data.
^C
edumazet@edumazet-laptop:~$ ip ro get 4.4.4.4
4.4.4.4 dev ppp0 src 10.150.51.210
cache ipid 0xf99a mtu 1500 advmss 1460 hoplimit 64
This on a 2.6.35 kernel
I suspect Alessandro tool had a bug anyway.
next prev parent reply other threads:[~2011-03-24 22:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 15:08 regression: ip r change mss doesn't work in 2.6.38-git14 Alessandro Suardi
2011-03-24 15:21 ` Eric Dumazet
2011-03-24 15:52 ` Alessandro Suardi
2011-03-24 16:15 ` Eric Dumazet
2011-03-24 17:01 ` [PATCH] ipv4: fix fib metrics Eric Dumazet
2011-03-24 18:14 ` Alessandro Suardi
2011-03-24 18:45 ` Eric Dumazet
2011-03-24 22:11 ` Alessandro Suardi
2011-03-24 22:18 ` Eric Dumazet
2011-03-24 22:27 ` Alessandro Suardi
2011-03-24 22:32 ` Eric Dumazet
2011-03-24 22:36 ` David Miller
2011-03-24 22:44 ` Eric Dumazet [this message]
2011-03-25 0:12 ` Alessandro Suardi
2011-03-25 0:22 ` David Miller
2011-03-25 0:53 ` Kyle Moffett
2011-03-25 1:04 ` Alessandro Suardi
2011-03-25 1:25 ` Alessandro Suardi
2011-05-27 9:27 ` David Woodhouse
2011-05-28 22:00 ` Alessandro Suardi
2011-03-24 18:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301006652.2714.145.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=alessandro.suardi@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox