Re: [PATCH net-next] net-ethtool: Allow ethtool to set interface in loopback mode.

[Ben Hutchings <bhutchings@solarflare.com>]

On Tue, 2011-03-29 at 15:39 +0200, Michał Mirosław wrote:
> On Tue, Mar 29, 2011 at 12:48:43AM +0100, Ben Hutchings wrote:
> > I'm sorry that things keep changing under your feet.  Unfortunately I'm
> > going to have to ask for more changes; see below.
> > 
> > I'm cc'ing Michał Mirosław so he can comment on how he thinks the
> > generic feature handling should be extended.
> > 
> > On Mon, 2011-03-28 at 15:24 -0700, Mahesh Bandewar wrote:
> > > Add second word for feature (currently it's single word). Also use the first
> > > bit of the second word to set the loopback mode. By configuring the interface
> > > in loopback mode in conjunction with a policy route / rule, a user-land
> > > application can stress the egress / ingress path exposing the flows of the
> > > change in progress and potentially help developer(s) understand the impact of
> > > those changes without even sending a packet out on the network.
> 
> For one, adding more feature words should be separate patch to the one
> introducing loopback mode.
> 
> Unless I missed some patches, there's still one or two bits left in features
> you can use. This will be a lot less work for you.
[...]

I recommended Mahesh to use a second word for this flag because it is
not something the networking stack needs to be aware of.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.