* [PATCH] net/bridge: Fix wrong return-no-vaule
@ 2011-04-01 4:24 namei.unix
2011-04-01 18:11 ` [Bridge] " Sasikanth V
0 siblings, 1 reply; 2+ messages in thread
From: namei.unix @ 2011-04-01 4:24 UTC (permalink / raw)
To: shemminger, davem
Cc: Liu Yuan, open list:ETHERNET BRIDGE, open list:ETHERNET BRIDGE,
open list
From: Liu Yuan <tailai.ly@taobao.com>
In br_stp_if.c/br_stp_recalculate_bridge_id, it should return
false, which indicates that there is no change when we find
that user has chosen a value.
Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
---
net/bridge/br_stp_if.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
index 5593f5a..9b61d09 100644
--- a/net/bridge/br_stp_if.c
+++ b/net/bridge/br_stp_if.c
@@ -213,7 +213,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br)
/* user has chosen a value so keep it */
if (br->flags & BR_SET_MAC_ADDR)
- return;
+ return false;
list_for_each_entry(p, &br->port_list, list) {
if (addr == br_mac_zero ||
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Bridge] [PATCH] net/bridge: Fix wrong return-no-vaule
2011-04-01 4:24 [PATCH] net/bridge: Fix wrong return-no-vaule namei.unix
@ 2011-04-01 18:11 ` Sasikanth V
0 siblings, 0 replies; 2+ messages in thread
From: Sasikanth V @ 2011-04-01 18:11 UTC (permalink / raw)
To: namei.unix
Cc: shemminger, davem, open list:ETHERNET BRIDGE, Liu Yuan,
open list:ETHERNET BRIDGE, open list
It is already fixed and applied
On 4/1/11, namei.unix@gmail.com <namei.unix@gmail.com> wrote:
> From: Liu Yuan <tailai.ly@taobao.com>
>
> In br_stp_if.c/br_stp_recalculate_bridge_id, it should return
> false, which indicates that there is no change when we find
> that user has chosen a value.
>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
> net/bridge/br_stp_if.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
> index 5593f5a..9b61d09 100644
> --- a/net/bridge/br_stp_if.c
> +++ b/net/bridge/br_stp_if.c
> @@ -213,7 +213,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br)
>
> /* user has chosen a value so keep it */
> if (br->flags & BR_SET_MAC_ADDR)
> - return;
> + return false;
>
> list_for_each_entry(p, &br->port_list, list) {
> if (addr == br_mac_zero ||
> --
> 1.7.1
>
> _______________________________________________
> Bridge mailing list
> Bridge@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/bridge
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-01 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-01 4:24 [PATCH] net/bridge: Fix wrong return-no-vaule namei.unix
2011-04-01 18:11 ` [Bridge] " Sasikanth V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).