netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev <netdev@vger.kernel.org>
Subject: NETIF_F_TSO vs NETIF_F_TSO{6,_ECN}
Date: Tue, 05 Apr 2011 16:50:02 +0100	[thread overview]
Message-ID: <1302018602.2932.22.camel@bwh-desktop> (raw)

According to the commit that introduced NETIF_F_TSO6
(f83ef8c0b58dac17211a4c0b6df0e2b1bd6637b1):
    
        This patch will introduce a new flag NETIF_F_TSO6 which will be used
        to check whether device supports TSO over IPv6. If device support TSO
        over IPv6 then we don't clear of NETIF_F_TSO and which will make the
        TCP layer to create TSO packets. Any device supporting TSO over IPv6
        will set NETIF_F_TSO6 flag in "dev->features" along with NETIF_F_TSO.
    
        In case when user disables TSO using ethtool, NETIF_F_TSO will get
        cleared from "dev->features". So even if we have NETIF_F_TSO6 we don't
        get TSO packets created by TCP layer.

So I think we need to either:
1. Disallow toggling NETIF_F_TSO6 (following the previous rule)
2. Disable NETIF_F_TSO6 when NETIF_F_TSO is disabled

The same presumably applies to NETIF_F_TSO_ECN.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


             reply	other threads:[~2011-04-05 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 15:50 Ben Hutchings [this message]
2011-04-05 18:03 ` NETIF_F_TSO vs NETIF_F_TSO{6,_ECN} Michał Mirosław
2011-04-05 18:31   ` Ben Hutchings
2011-04-06 21:22     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302018602.2932.22.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).