netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	sf-linux-drivers <linux-net-drivers@solarflare.com>,
	"Stephen Hemminger" <shemminger@vyatta.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: pull request: sfc-next-2.6 2011-04-05
Date: Tue, 05 Apr 2011 19:00:46 +0100	[thread overview]
Message-ID: <1302026446.2932.56.camel@bwh-desktop> (raw)

The following changes since commit 9b12c75bf4d58dd85c987ee7b6a4356fdc7c1222:

  net: Order ports in same order as addresses in flow objects. (2011-03-31 18:03:35 -0700)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/bwh/sfc-next-2.6.git for-davem

1. Implement generic features interface in sfc.
2. Update ethtool_ops documentation.
3. Reimplement ETHTOOL_PHYS_ID as dicussed, dropping the RTNL lock.

Changes since the previous request:

1a. Drop NETIF_F_GRO from net_device::features; let the core enable it.
1b. Add NETIF_F_ALL_TSO and NETIF_F_RXCSUM to net_device::vlan_features;
TSO-IPv6 and RX checksum offload do work with VLAN-tagged packets.
2. In comments on deprecated offload control operations, refer to
'generic netdev features' rather than 'the netdev op ndo_set_flags'.
Add a note at the bottom referring to struct net_device and struct
net_device_ops.
3a. Change comment 'must set the state' to 'should set the state'. We
don't really care if ON and OFF get inverted, and some of Stephen's
implementations just invert the LED state in either case.
3b. Prevent reentry of the ETHTOOL_PHYS_ID loop.

Ben.

Ben Hutchings (7):
      sfc: Move test of rx_checksum_enabled from nic.c to rx.c
      sfc: Enable all TSO features on VLANs
      sfc: Implement generic features interface
      ethtool: Convert struct ethtool_ops comment to kernel-doc format
      ethtool: Fill out and update comment for struct ethtool_ops
      ethtool: Change ETHTOOL_PHYS_ID implementation to allow dropping RTNL
      sfc: Implement ethtool_ops::set_phys_id instead of ethtool_ops::phys_id

 drivers/net/sfc/efx.c        |   20 ++++-
 drivers/net/sfc/ethtool.c    |  106 ++++--------------------
 drivers/net/sfc/net_driver.h |    2 -
 drivers/net/sfc/nic.c        |    6 +-
 drivers/net/sfc/rx.c         |    3 +
 include/linux/ethtool.h      |  180 ++++++++++++++++++++++++++++++------------
 net/core/ethtool.c           |   55 ++++++++++++-
 7 files changed, 223 insertions(+), 149 deletions(-)

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


             reply	other threads:[~2011-04-05 18:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 18:00 Ben Hutchings [this message]
2011-04-05 18:02 ` [PATCHv2 net-next-2.6 1/7] sfc: Move test of rx_checksum_enabled from nic.c to rx.c Ben Hutchings
2011-04-05 18:02 ` [PATCHv2 net-next-2.6 2/7] sfc: Enable all TSO features on VLANs Ben Hutchings
2011-04-05 18:03 ` [PATCHv2 net-next-2.6 3/7] sfc: Implement generic features interface Ben Hutchings
2011-04-05 18:15   ` Michał Mirosław
2011-04-05 18:20     ` Ben Hutchings
2011-04-05 18:29       ` Michał Mirosław
2011-04-05 18:03 ` [PATCHv2 net-next-2.6 4/7] ethtool: Convert struct ethtool_ops comment to kernel-doc format Ben Hutchings
2011-04-05 18:04 ` [PATCH net-next-2.6 5/7] ethtool: Fill out and update comment for struct ethtool_ops Ben Hutchings
2011-04-05 18:05 ` [PATCHv2 net-next-2.6 6/7] ethtool: Change ETHTOOL_PHYS_ID implementation to allow dropping RTNL Ben Hutchings
2011-04-05 18:07 ` [PATCHv2 net-next-2.6 7/7] sfc: Implement ethtool_ops::set_phys_id instead of ethtool_ops::phys_id Ben Hutchings
2011-04-06 19:29 ` pull request: sfc-next-2.6 2011-04-05 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302026446.2932.56.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=linux-net-drivers@solarflare.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).