From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
linux-net-drivers@solarflare.com,
"Michał Mirosław" <mirqus@gmail.com>
Subject: Re: [PATCH net-next-2.6 5/6] ethtool: Change ETHTOOL_PHYS_ID implementation to allow dropping RTNL
Date: Tue, 05 Apr 2011 21:21:38 +0100 [thread overview]
Message-ID: <1302034898.2932.119.camel@bwh-desktop> (raw)
In-Reply-To: <20110404180123.702bd14e@nehalam>
On Mon, 2011-04-04 at 18:01 -0700, Stephen Hemminger wrote:
> On Tue, 05 Apr 2011 00:26:31 +0100
> Ben Hutchings <bhutchings@solarflare.com> wrote:
>
> > This reimplementation lets us blink LEDs on multiple device at the same
> > time, but that's pretty pointless. The nasty thing is we could try to
> > blink LEDs twice over on the same device, violating the rules that the
> > drivers depend on. So I think I need to add:
> >
>
> This looks sane, is there a good way to fix the qlge and cxgb4 drivers
> and get rid of the old interface?
Prod the respective maintainers?
(Wow, using device firmware to implement a delay, that's special.)
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-05 20:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 19:44 pull request: sfc-next-2.6 2011-04-03 Ben Hutchings
2011-04-03 19:50 ` [PATCH net-next-2.6 1/6] sfc: Move test of rx_checksum_enabled from nic.c to rx.c Ben Hutchings
2011-04-03 19:51 ` [PATCH net-next-2.6 2/6] sfc: Implement generic features interface Ben Hutchings
2011-04-03 20:13 ` Michał Mirosław
2011-04-03 20:27 ` Ben Hutchings
2011-04-03 20:50 ` Michał Mirosław
2011-04-03 19:51 ` [PATCH net-next-2.6 3/6] ethtool: Convert struct ethtool_ops comment to kernel-doc format Ben Hutchings
2011-04-03 19:52 ` [PATCH net-next-2.6 4/6] ethtool: Fill out and update comment for struct ethtool_ops Ben Hutchings
2011-04-03 21:25 ` Michał Mirosław
2011-04-03 21:36 ` Ben Hutchings
2011-04-03 19:53 ` [PATCH net-next-2.6 5/6] ethtool: Change ETHTOOL_PHYS_ID implementation to allow dropping RTNL Ben Hutchings
2011-04-04 23:26 ` Ben Hutchings
2011-04-05 1:01 ` Stephen Hemminger
2011-04-05 20:21 ` Ben Hutchings [this message]
2011-04-03 19:55 ` [PATCH net-next-2.6 6/6] sfc: Implement ethtool_ops::set_phys_id instead of ethtool_ops::phys_id Ben Hutchings
2011-04-04 0:50 ` pull request: sfc-next-2.6 2011-04-03 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302034898.2932.119.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).