From: Joe Perches <joe@perches.com>
To: Matt Carlson <mcarlson@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 3/9] tg3: Reintroduce 5717_PLUS
Date: Tue, 05 Apr 2011 22:30:53 -0700 [thread overview]
Message-ID: <1302067853.1683.29.camel@Joe-Laptop> (raw)
In-Reply-To: <1302049371-13799-4-git-send-email-mcarlson@broadcom.com>
On Tue, 2011-04-05 at 17:22 -0700, Matt Carlson wrote:
> This patch reintroduces the TG3_FLG3_5717_PLUS to identify 5717 and
> later devices.
[]
> @@ -13427,8 +13422,7 @@ static int __devinit tg3_get_invariants(struct tg3 *tp)
[]
> + if (tp->tg3_flags3 & TG3_FLG3_5717_PLUS)
> tp->tg3_flags3 |= TG3_FLG3_LRG_PROD_RING_CAP;
This seems redundant. Maybe consolidate to just
TG3_FLG3_5717_PLUS and remove LRG_PROD_RING_CAP?
I don't know if these attributes really are linked.
Another option may be to use DECLARE_BITMAP
and set_bit/test_bit so there's no real need
to use FLAG/FLG2/FLG3, etc.
next prev parent reply other threads:[~2011-04-06 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 0:22 [PATCH v2 net-next 3/9] tg3: Reintroduce 5717_PLUS Matt Carlson
2011-04-06 5:30 ` Joe Perches [this message]
2011-04-06 17:33 ` Matt Carlson
2011-04-06 18:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302067853.1683.29.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox