netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Wood <simon@mungewell.org>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
	davem@davemloft.net, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simon Wood <simon@mungewell.org>
Subject: [PatchV3 3/3] usb: plusb: Add debug to reset function
Date: Thu,  7 Apr 2011 00:40:15 -0700	[thread overview]
Message-ID: <1302162015-22504-3-git-send-email-simon@mungewell.org> (raw)
In-Reply-To: <1302162015-22504-1-git-send-email-simon@mungewell.org>

From: simon <simon@ubuntu.(none)>

This patch adds some debug to the reset function to print out the
reason why it fails.

Signed-off-by: Simon Wood <simon@mungewell.org>
---
 drivers/net/usb/plusb.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c
index f46aa07..217aec8 100644
--- a/drivers/net/usb/plusb.c
+++ b/drivers/net/usb/plusb.c
@@ -94,11 +94,15 @@ pl_set_QuickLink_features(struct usbnet *dev, int val)
 
 static int pl_reset(struct usbnet *dev)
 {
+	int status;
+
 	/* some units seem to need this reset, others reject it utterly.
 	 * FIXME be more like "naplink" or windows drivers.
 	 */
-	(void) pl_set_QuickLink_features(dev,
+	status = pl_set_QuickLink_features(dev,
 		PL_S_EN|PL_RESET_OUT|PL_RESET_IN|PL_PEER_E);
+	if (status != 0 && netif_msg_probe(dev))
+		netif_dbg(dev, link, dev->net, "pl_reset --> %d\n", status);
 	return 0;
 }
 
-- 
1.7.4.1

  parent reply	other threads:[~2011-04-07  7:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30  3:44 [PATCH] pl25a1_support Simon Wood
2011-03-30  9:40 ` David Miller
2011-03-30 11:31 ` Sergei Shtylyov
2011-04-06  4:16 ` [PatchV2 : PL25A1 Support - 1/3] whitespace Simon Wood
2011-04-06 20:17   ` David Miller
     [not found] ` <1301456667-1648-1-git-send-email-simon-wM4F9T/ekXmXDw4h08c5KA@public.gmane.org>
2011-04-06  4:16   ` [PatchV2 : PL25A1 Support - 2/3] add_pl25a1 Simon Wood
2011-04-06  4:16 ` [PatchV2 : PL25A1 Support - 3/3] reset_debug Simon Wood
2011-04-07  7:40 ` [PatchV3 1/3] usb: plusb: Whitespace Simon Wood
2011-04-07  7:40   ` [PatchV3 2/3] usb: plusb: Add support for PL-25A1 Simon Wood
2011-04-11  1:47     ` David Miller
2011-04-07  7:40   ` Simon Wood [this message]
2011-04-11  1:47     ` [PatchV3 3/3] usb: plusb: Add debug to reset function David Miller
2011-04-11  1:47   ` [PatchV3 1/3] usb: plusb: Whitespace David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302162015-22504-3-git-send-email-simon@mungewell.org \
    --to=simon@mungewell.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).