From: David Dillow <dave@thedillows.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, Francois Romieu <romieu@fr.zoreil.com>
Subject: Re: [PATCH] net: r8169: convert to hw_features
Date: Fri, 08 Apr 2011 11:37:47 -0400 [thread overview]
Message-ID: <1302277067.19764.2.camel@obelisk.thedillows.org> (raw)
In-Reply-To: <20110408124406.GA22478@rere.qmqm.pl>
On Fri, 2011-04-08 at 14:44 +0200, Michał Mirosław wrote:
> On Fri, Apr 08, 2011 at 02:38:46PM +0200, Michał Mirosław wrote:
> > This enables SG+IP_CSUM+TSO by default (there were no comments suggesting
> > leaving them out was intentional).
> >
> > This also fixes confusion around vlan_features in rtl8169_vlan_mode().
>
> BTW, I noticed that TSO will break for MTU > 4095+(TCP+IP header len).
> This needs handing in ndo_fix_features callback like other MTU-limited TSO
> engines.
I'd suggest leaving SG/CSUM/TSO off by default -- I played with getting
them working some time ago, and IIRC the current code doesn't handle all
devices properly. Add the issue you note above and you are knowingly
leaving landmines laying about for users of a popular piece of hardware.
Realtek, Francois, please correct me if I'm mistaken.
Dave
next prev parent reply other threads:[~2011-04-08 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 12:38 [PATCH] net: r8169: convert to hw_features Michał Mirosław
2011-04-08 12:44 ` Michał Mirosław
2011-04-08 15:37 ` David Dillow [this message]
2011-04-08 16:35 ` [PATCH v2] " Michał Mirosław
2011-04-11 1:55 ` David Miller
[not found] ` <20110410154508.GA17091@electric-eye.fr.zoreil.com>
2011-04-11 13:30 ` Michał Mirosław
2011-04-11 18:47 ` François Romieu
2011-04-11 19:15 ` Michał Mirosław
2011-04-11 19:30 ` François Romieu
2011-04-12 2:10 ` hayeswang
2011-04-13 17:47 ` François Romieu
[not found] ` <1302718764.3167.7.camel@lap75545.ornl.gov>
2011-04-18 18:08 ` Francois Romieu
2011-04-19 3:24 ` David Dillow
2011-04-19 5:54 ` David Miller
2011-04-20 19:13 ` Francois Romieu
2011-04-20 19:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302277067.19764.2.camel@obelisk.thedillows.org \
--to=dave@thedillows.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).