From: Ben Hutchings <bhutchings@solarflare.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org
Subject: Re: [ethtool PATCH 1/2] ethtool: fix manpage so that it will display tables again
Date: Fri, 08 Apr 2011 23:45:38 +0100 [thread overview]
Message-ID: <1302302738.2871.36.camel@bwh-desktop> (raw)
In-Reply-To: <20110408221234.26893.58812.stgit@gitlad.jf.intel.com>
On Fri, 2011-04-08 at 15:12 -0700, Alexander Duyck wrote:
> The current ethtool manpage is not displaying tables. After trying to pass
> the manpage through tbl I repeatedly saw the error:
> tbl:ethtool.8.in:707: unrecognised format `x'
> tbl:ethtool.8.in:707: giving up on this table
>
> By dropping the 'x' the errors went away and when I built the manpage the
> tables reappeared so I am assuming this is the correct approach.
[...]
I think this must depend somewhat on the version of tbl. I must admit I
haven't yet tested with a range of versions.
In groff 1.20.1, the 'x' column flag requested an 'expanded' column
which will be as wide as possible (after allowing for the other column
contents) with its contents word-wrapped if necessary. Without this
flag, tbl wraps some columns poorly and complains about some tables
being too wide (though I don't think they are). Clearly that is less
bad than having it discard the tables altogether, so I will apply this.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-08 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 22:12 [ethtool PATCH 0/2] Minor ethtool cleanups Alexander Duyck
2011-04-08 22:12 ` [ethtool PATCH 1/2] ethtool: fix manpage so that it will display tables again Alexander Duyck
2011-04-08 22:45 ` Ben Hutchings [this message]
2011-04-08 22:12 ` [ethtool PATCH 2/2] Add support for ESP as a separate protocol from AH Alexander Duyck
2011-04-08 23:10 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302302738.2871.36.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox