Re: [PATCH v4] net: bnx2x: convert to hw_features

Vladislav Zolotarov
2011-04-13T09:36:58Z

> Hmm. I thought one, and wrote another.
>
> Since bnx2x_parity_recover() runs with rtnl_lock(), as should
> netdev_update_features(), then in case the recovery is in progress
> it should be enough to not call bnx2x_reload_if_running() then
> and just change the flags --- changes will be picked up on bnx2x_nic_load()
> after recovery is complete. This removes the need for netdev_update_features()
> calls.
>

Ok. I see what u meant in v5... ;)
The patch is great. Thanks for your work. There are some enhancements
following your patch that I have in mind that I'll submit later.

thanks again, Michal.