netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: <linuxppc-dev@lists.ozlabs.org>, <linux.nics@intel.com>,
	<auke-jan.h.kok@intel.com>, <e1000-devel@lists.sourceforge.net>,
	<netdev@vger.kernel.org>
Cc: <meet2prabhu@gmail.com>, Prabhakar <prabhakar@freescale.com>,
	Jin Qing <b24347@freescale.com>
Subject: [PATCH] driver/e1000e: Fix default interrupt mode select
Date: Tue, 12 Apr 2011 10:26:03 +0530	[thread overview]
Message-ID: <1302584163-22318-1-git-send-email-prabhakar@freescale.com> (raw)

From: Prabhakar <prabhakar@freescale.com>

The Intel e1000 device driver defaults to MSI interrupt mode, even if MSI
support is not enabled

Signed-off-by: Jin Qing <b24347@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
 Based upon git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branch master)

 added  netdev mail-list and e1000 mail-list & maintainer

 drivers/net/e1000e/param.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/e1000e/param.c b/drivers/net/e1000e/param.c
index a150e48..7b3bbec 100644
--- a/drivers/net/e1000e/param.c
+++ b/drivers/net/e1000e/param.c
@@ -390,7 +390,11 @@ void __devinit e1000e_check_options(struct e1000_adapter *adapter)
 			.type = range_option,
 			.name = "Interrupt Mode",
 			.err  = "defaulting to 2 (MSI-X)",
+#ifdef CONFIG_PCI_MSI
 			.def  = E1000E_INT_MODE_MSIX,
+#else
+			.def  = E1000E_INT_MODE_LEGACY,
+#endif
 			.arg  = { .r = { .min = MIN_INTMODE,
 					 .max = MAX_INTMODE } }
 		};
-- 
1.7.3



             reply	other threads:[~2011-04-12  4:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  4:56 Prabhakar Kushwaha [this message]
2011-04-12 21:27 ` [PATCH] driver/e1000e: Fix default interrupt mode select David Miller
2011-04-12 21:31   ` Jeff Kirsher
2011-04-12 21:32 ` [E1000-devel] " Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302584163-22318-1-git-send-email-prabhakar@freescale.com \
    --to=prabhakar@freescale.com \
    --cc=auke-jan.h.kok@intel.com \
    --cc=b24347@freescale.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=linux.nics@intel.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=meet2prabhu@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).