From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Steve Hodgson <shodgson@solarflare.com>,
Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sfc: make function tables const
Date: Thu, 14 Apr 2011 17:37:18 +0100 [thread overview]
Message-ID: <1302799038.2853.5.camel@bwh-desktop> (raw)
In-Reply-To: <20110414085012.3e45d7b4@nehalam>
On Thu, 2011-04-14 at 08:50 -0700, Stephen Hemminger wrote:
> The phy, mac, and board information structures should be const.
efx_nic_type actually holds information and function pointers about
different generations of the controller, not different boards.
> Since tables contain function pointer this improves security
> (at least theoretically).
>
> Compile tested only.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-14 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 15:50 [PATCH net-next] sfc: make function tables const Stephen Hemminger
2011-04-14 16:37 ` Ben Hutchings [this message]
2011-04-15 4:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302799038.2853.5.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=shodgson@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).