netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: "Fejes József" <fejes@joco.name>
Cc: "François Romieu" <romieu@fr.zoreil.com>, netdev@vger.kernel.org
Subject: Re: r8169 misleading firmware error messages
Date: Sat, 16 Apr 2011 16:34:23 +0100	[thread overview]
Message-ID: <1302968063.5282.859.camel@localhost> (raw)
In-Reply-To: <4DA9864E.2070405@joco.name>

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Sat, 2011-04-16 at 14:06 +0200, Fejes József wrote:
[...]
> I took a deeper look. It seems to me that the firmware files are not the 
> usual microcode type that the device can't function without, it just 
> sets up some registers, which supposedly already contain some sensible 
> values, so it's more like patching.

Some of the R8169 variants have a microcontroller in the PHY running
firmware that is initially loaded from non-volatile memory (maybe
eFuse?).  These blobs contain bug fixes for the original PHY firmware.

> That explains why this device still 
> works without the firmware. So my actual question is this: what do I 
> gain if I use the firmware, what do I lose if I don't?
[...]

The original firmware apparently is unable to establish a stable link
against some link partners.

This warning:

> W: Possible missing firmware /lib/firmware/rtl_nic/rtl8168d-2.fw for 
> module r8169
> W: Possible missing firmware /lib/firmware/rtl_nic/rtl8168d-1.fw for 
> module r8169

is purely based on the MODULE_FIRMWARE annotations, which do not
distinguish which devices might require which files.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2011-04-16 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16  8:27 r8169 misleading firmware error messages Fejes József
2011-04-16 11:04 ` François Romieu
2011-04-16 12:06   ` Fejes József
2011-04-16 15:34     ` Ben Hutchings [this message]
2011-04-17 14:38     ` François Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302968063.5282.859.camel@localhost \
    --to=ben@decadent.org.uk \
    --cc=fejes@joco.name \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).