From: David Decotigny <decot@google.com>
To: Jes Sorensen <jes@trained-monkey.org>,
linux-acenic@sunsite.dk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: David Decotigny <decot@google.com>
Subject: [PATCH] acenic: Fix using the specified speed when configuring NIC
Date: Sat, 16 Apr 2011 17:57:07 -0700 [thread overview]
Message-ID: <1303001827-4283-1-git-send-email-decot@google.com> (raw)
This patch needs review, as I did not test it: I only think something
is weird by looking at the code, but experts must confirm.
This tells the NIC to take the speed specified by ethtool into account
when configuring the NIC, instead of keeping the previous speed.
Signed-off-by: David Decotigny <decot@google.com>
---
drivers/net/acenic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c
index a579899..82260ca 100644
--- a/drivers/net/acenic.c
+++ b/drivers/net/acenic.c
@@ -2720,7 +2720,7 @@ static int ace_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
link |= LNK_NEGOTIATE;
if (ethtool_cmd_speed(ecmd) != speed) {
link &= ~(LNK_1000MB | LNK_100MB | LNK_10MB);
- switch (speed) {
+ switch (ethtool_cmd_speed(ecmd)) {
case SPEED_1000:
link |= LNK_1000MB;
break;
--
1.7.3.1
next reply other threads:[~2011-04-17 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 0:57 David Decotigny [this message]
2011-04-19 5:46 ` [PATCH] acenic: Fix using the specified speed when configuring NIC David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303001827-4283-1-git-send-email-decot@google.com \
--to=decot@google.com \
--cc=jes@trained-monkey.org \
--cc=linux-acenic@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).