From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven Eckelmann Subject: =?utf-8?q?=5BPATCH_8/8=5D_batman-adv=3A_Set_the_tx?= =?utf-8?q?queuelen_to_zero_when_creating_soft_interface?= Date: Sun, 17 Apr 2011 21:30:18 +0200 Message-ID: <1303068618-27928-9-git-send-email-sven@narfation.org> References: <1303068618-27928-1-git-send-email-sven@narfation.org> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org, Marek Lindner To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org Return-path: In-Reply-To: <1303068618-27928-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org From: Andrew Lunn Like other virtual interfaces, e.g. br0, we don't need a transmit queue. Packets should only be queued on real interfaces which are underneath. In practice this patch makes little difference since the virtual interfaces can accept packets as fast as they come, but the patch will avoid bufferbloat questions to the mailling lists in the future. Signed-off-by: Andrew Lunn Tested-by: Linus L=C3=BCssing Signed-off-by: Marek Lindner Signed-off-by: Sven Eckelmann --- net/batman-adv/soft-interface.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interf= ace.c index a60fd48..1f6f756 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -584,6 +584,7 @@ static void interface_setup(struct net_device *dev) dev->hard_start_xmit =3D interface_tx; #endif dev->destructor =3D free_netdev; + dev->tx_queue_len =3D 0; =20 /** * can't call min_mtu, because the needed variables --=20 1.7.4.4