From: Ben Hutchings <bhutchings@solarflare.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Ciprian Docan <docan@eden.rutgers.edu>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"Rafael, J. Wysocki" <rjw@sisk.pl>, Greg KH <gregkh@suse.de>
Subject: Re: Suspend/resume - slow resume
Date: Mon, 18 Apr 2011 20:25:36 +0100 [thread overview]
Message-ID: <1303154736.2857.46.camel@bwh-desktop> (raw)
In-Reply-To: <BANLkTim_1OgqjCeD1a4Ay2fWJSmPHa_XTQ@mail.gmail.com>
On Mon, 2011-04-18 at 11:49 -0700, Linus Torvalds wrote:
> On Mon, Apr 18, 2011 at 11:08 AM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> > [...]
> >> - unload not on close, but on device unregister (iow not when you do
> >> "ifconfig eth0 down", but when the "eth0" device really goes away)
> >
> > Without further action, the firmware(s) will thus be locked in until the
> > driver is removed.
>
> I do agree. It's a downside. Maybe doing it in "close()" is the right
> thing, as long as we don't have that crazy "every four timer ticks"
> situation with rtl8169_reinit_task.
>
> As mentioned, the only real reason for me to be worried about the
> close thing is that I don't have a good feel for what happens at boot
> time. Are the setup scripts going to look at the interface lots of
> times? On my desktop, I couldn't care less, but I try to keep boot
> time in mind.
>
> Maybe in practice there's just a single open at boot-time (for dhcp or
> whatever), and I'm just worried for no good reason.
[...]
Well, net devices are weird - they don't have file descriptors, they
just have names and indices which you can specify in an ioctl on any
socket (or netlink message on an appropriate netlink socket). Opening
means starting the device, and I can't think of a configuration tool
that implicitly opens a net device. Normally they get opened by ifup or
network-manager or the local equivalent, and then they stay open until
an explicit action by the administrator.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-18 19:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.SOC.4.64.1104150931390.1320@er3.rutgers.edu>
[not found] ` <BANLkTinO+HFq+Mgg1aUz9V==zYs7qSBtDw@mail.gmail.com>
[not found] ` <Pine.SOC.4.64.1104151122330.1320@er3.rutgers.edu>
2011-04-15 16:14 ` Suspend/resume - slow resume Linus Torvalds
2011-04-17 10:17 ` Francois Romieu
2011-04-17 16:42 ` Linus Torvalds
2011-04-18 18:08 ` Francois Romieu
2011-04-18 18:49 ` Linus Torvalds
2011-04-18 19:25 ` Ben Hutchings [this message]
2011-04-18 19:27 ` Ciprian Docan
2011-04-18 19:51 ` Linus Torvalds
2011-04-20 18:16 ` Francois Romieu
2011-04-20 18:51 ` Ciprian Docan
2011-04-20 19:52 ` Francois Romieu
2011-04-20 19:10 ` Ciprian Docan
2011-04-20 19:53 ` Francois Romieu
2011-04-21 2:07 ` Ciprian Docan
2011-04-21 13:02 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303154736.2857.46.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=docan@eden.rutgers.edu \
--cc=gregkh@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=romieu@fr.zoreil.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).