From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: Suspend/resume - slow resume Date: Mon, 18 Apr 2011 20:25:36 +0100 Message-ID: <1303154736.2857.46.camel@bwh-desktop> References: <20110417101731.GA17986@electric-eye.fr.zoreil.com> <20110418180813.GA18469@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Francois Romieu , Ciprian Docan , netdev@vger.kernel.org, Linux Kernel Mailing List , Len Brown , Pavel Machek , "Rafael, J. Wysocki" , Greg KH To: Linus Torvalds Return-path: Received: from mail.solarflare.com ([216.237.3.220]:9321 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756591Ab1DRTZk (ORCPT ); Mon, 18 Apr 2011 15:25:40 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2011-04-18 at 11:49 -0700, Linus Torvalds wrote: > On Mon, Apr 18, 2011 at 11:08 AM, Francois Romieu wrote: > > [...] > >> - unload not on close, but on device unregister (iow not when you do > >> "ifconfig eth0 down", but when the "eth0" device really goes away) > > > > Without further action, the firmware(s) will thus be locked in until the > > driver is removed. > > I do agree. It's a downside. Maybe doing it in "close()" is the right > thing, as long as we don't have that crazy "every four timer ticks" > situation with rtl8169_reinit_task. > > As mentioned, the only real reason for me to be worried about the > close thing is that I don't have a good feel for what happens at boot > time. Are the setup scripts going to look at the interface lots of > times? On my desktop, I couldn't care less, but I try to keep boot > time in mind. > > Maybe in practice there's just a single open at boot-time (for dhcp or > whatever), and I'm just worried for no good reason. [...] Well, net devices are weird - they don't have file descriptors, they just have names and indices which you can specify in an ioctl on any socket (or netlink message on an appropriate netlink socket). Opening means starting the device, and I can't think of a configuration tool that implicitly opens a net device. Normally they get opened by ifup or network-manager or the local equivalent, and then they stay open until an explicit action by the administrator. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.