From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dmitry Kravkov <dmitry@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: [BUG] bnx2x: bnx2x_set_pbd_csum() random accesses
Date: Tue, 19 Apr 2011 18:11:43 +0200 [thread overview]
Message-ID: <1303229503.3480.386.camel@edumazet-laptop> (raw)
Hi guys
bnx2x_set_pbd_csum() / bnx2x_set_pbd_csum_e2() seem to read
tcp_hdrlen(skb) even for non TCP frames ?
Also, (skb_network_header(skb) - skb->data) is signed, so
(skb_network_header(skb) - skb->data) / 2 is a bit expensive...
Thanks
next reply other threads:[~2011-04-19 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 16:11 Eric Dumazet [this message]
2011-04-20 7:31 ` [PATCH] bnx2x: dont dereference tcp header on non tcp frames Eric Dumazet
2011-04-20 8:46 ` David Miller
2011-04-20 9:40 ` Dmitry Kravkov
2011-04-20 15:08 ` Dmitry Kravkov
2011-04-22 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303229503.3480.386.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox