Re: [PATCH] bnx2x: dont dereference tcp header on non tcp frames

David Miller
2011-04-22T00:20:46Z

From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Wed, 20 Apr 2011 12:40:10 +0300

> On Wed, 2011-04-20 at 01:46 -0700, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Wed, 20 Apr 2011 09:31:53 +0200
>>
>> > [PATCH] bnx2x: dont dereference tcp header on non tcp frames
>> >
>> > bnx2x_set_pbd_csum() & bnx2x_set_pbd_csum_e2() use
>> > tcp_hdrlen(skb) even for non TCP frames
>> >
>> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> Broadcom folks please review.
>>
>
> Following patch fixes udp checksum offload flow and also addresses
> issues raised by Eric. We are testing it now.
>
> From: Vladislav Zolotarov <vladz@broadcom.com>
>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>

Can you guys please wrap this up and formally submit this patch?

Please remember to add appropriate tags for Eric, probably both
"Reported-by: " and "Tested-by: ".

Thank you!