From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D17C433EF for ; Wed, 8 Jun 2022 18:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232535AbiFHSxf (ORCPT ); Wed, 8 Jun 2022 14:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234248AbiFHSxd (ORCPT ); Wed, 8 Jun 2022 14:53:33 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E4B0179C39 for ; Wed, 8 Jun 2022 11:53:22 -0700 (PDT) Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4D5223F11D for ; Wed, 8 Jun 2022 18:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1654714378; bh=1xC7xuJX2LwCqZhAFi0xIy8j41xevuej7OLQ+ytw2nQ=; h=From:To:cc:Subject:In-reply-to:References:MIME-Version: Content-Type:Date:Message-ID; b=Yey4wV9LTtGV3TuTImVjgvASalfXnFMYvU14RjMxv3mQnw+fX8T8qq89Zy9uMb8gL WJ1wNVofzza4+GX3oHLjexerykjhZ5F3R0X4cNCBJEIUjaUsPkJVjB0Qk3S8PGZK8Q 80k8XeUvYcUrcJi0VUOFL43ADGlUYu9UWdxucVm4XkS4X/2zSqOTLRXUMd7hQvu+NW m6rUL3feTkiYKJ3cLmGqX7sv0u4xjC9Pb5Tg/hy0mAMQqBI/ESrwAKMguQb8LKV4Vh PpoaQr/Y9x9/SdGwdl3lWjcnGx7Ue5vu2Jysbva6pGgUWktyO4dM/tJ7oJ3WSHBX33 gDKCYjCIMo3ig== Received: by mail-pl1-f197.google.com with SMTP id u8-20020a170903124800b0015195a5826cso11557254plh.4 for ; Wed, 08 Jun 2022 11:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :comments:mime-version:content-id:date:message-id; bh=1xC7xuJX2LwCqZhAFi0xIy8j41xevuej7OLQ+ytw2nQ=; b=4oHBiEfWLFP44bm18/kSTp3zRekjC6IksK+rgtUoR3y90FEWjm5LlXURCWoaP/xRXL 9D1NGYrzBWvAqV5qxpVpiyn9INAOL/FoAeFuUV1W2vvtFGlHHHuXOZRz8Sm0ExlML+TH NnrWM5QsITb1Q5brn7Rj11vroumSUCKLi9sH4VHuP0s5NSBYWK9yfWyxzbGlg/zUKpD4 fmIylCDQyLDkOGYOPjZamxDdetO9CNA0QXfW5gkZuHqFMOZ7wF6OaKL5SATlxT1gZjop aZTy8tMXKxMBEjM6DTdu+sRqqjeSqbRYDZCIPPMqV15aeOEy78Y8Wg35M/uMsb5Ey3lh U34A== X-Gm-Message-State: AOAM533/G3E58jIEilt3W2sFtCXWngC2EiJpY3T/m21rLBU1ZI9oZbm9 7RjhD+c30crhNPePYbDg5KZEWCeMkveJqAABgCSdMRNGumwyLpfAPRsaQshFbmV3N/rBzofwPad z9aSIpZqoHUxS0VUEM78Pi2vCAfldNyTPEQ== X-Received: by 2002:a17:902:bd09:b0:162:1497:de0a with SMTP id p9-20020a170902bd0900b001621497de0amr35553391pls.64.1654714377008; Wed, 08 Jun 2022 11:52:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz23ty9fYIWfgAEUEgkcxRCNjUJTs0y3pIhLc6xx8m3HBunMKZC4fUMAvhK8ymRAtXm6HpymA== X-Received: by 2002:a17:902:bd09:b0:162:1497:de0a with SMTP id p9-20020a170902bd0900b001621497de0amr35553376pls.64.1654714376797; Wed, 08 Jun 2022 11:52:56 -0700 (PDT) Received: from famine.localdomain ([50.125.80.157]) by smtp.gmail.com with ESMTPSA id x22-20020a63cc16000000b003f9e80538d0sm15196943pgf.17.2022.06.08.11.52.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jun 2022 11:52:56 -0700 (PDT) Received: by famine.localdomain (Postfix, from userid 1000) id F0F1A62730; Wed, 8 Jun 2022 11:52:55 -0700 (PDT) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id E9D74A0B36; Wed, 8 Jun 2022 11:52:55 -0700 (PDT) From: Jay Vosburgh To: Jonathan Toppins cc: netdev@vger.kernel.org, Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [net-next v2 1/2] bonding: netlink error message support for options In-reply-to: <57acf609e89a35d4ea6ff901b3be3c5bb0071f78.1654711315.git.jtoppins@redhat.com> References: <57acf609e89a35d4ea6ff901b3be3c5bb0071f78.1654711315.git.jtoppins@redhat.com> Comments: In-reply-to Jonathan Toppins message dated "Wed, 08 Jun 2022 14:14:56 -0400." X-Mailer: MH-E 8.6+git; nmh 1.6; Emacs 29.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13032.1654714375.1@famine> Date: Wed, 08 Jun 2022 11:52:55 -0700 Message-ID: <13033.1654714375@famine> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jonathan Toppins wrote: >Add support for reporting errors via extack in both bond_newlink >and bond_changelink. > >Instead of having to look in the kernel log for why an option was not >correct just report the error to the user via the extack variable. > >What is currently reported today: > ip link add bond0 type bond > ip link set bond0 up > ip link set bond0 type bond mode 4 > RTNETLINK answers: Device or resource busy > >After this change: > ip link add bond0 type bond > ip link set bond0 up > ip link set bond0 type bond mode 4 > Error: unable to set option because the bond is up. > >Signed-off-by: Jonathan Toppins Acked-by: Jay Vosburgh