Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap

Matt Carlson
2011-04-27T16:15:34Z

On Tue, Apr 26, 2011 at 11:12:10AM -0700, Joe Perches wrote:
> Using a bitmap instead of separate u32 flags allows a consistent, simpler
> and more extensible mechanism to determine capabilities.
>
> Convert bitmasks to enum.
> Add tg3_flag, tg3_flag_clear and tg3_flag_set.
> Convert the flag & bitmask tests.
>
> Signed-off-by: Joe Perches <joe@perches.com>

I looked through it and didn't see any problems. I've queued
Michael Chan's suggestion into my queue.

Acked-by: Matt Carlson <mcarlson@broadcom.com>