Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap

David Miller
2011-04-28T20:43:15Z

From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Wed, 27 Apr 2011 09:28:21 -0700

> On Tue, Apr 26, 2011 at 11:12:10AM -0700, Joe Perches wrote:
>> Using a bitmap instead of separate u32 flags allows a consistent, simpler
>> and more extensible mechanism to determine capabilities.
>>
>> Convert bitmasks to enum.
>> Add tg3_flag, tg3_flag_clear and tg3_flag_set.
>> Convert the flag & bitmask tests.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> I looked through it and didn't see any problems. I've queued
> Michael Chan's suggestion into my queue.
>
> Acked-by: Matt Carlson <mcarlson@broadcom.com>

I've applied Joe's change to net-next-2.6, thanks everyone.