Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap

Joe Perches
2011-04-21T16:49:43Z

On Thu, 2011-04-21 at 10:31 +0200, Eric Dumazet wrote:
> Le mercredi 20 avril 2011 à 23:39 -0700, Joe Perches a écrit :
> > Using a bitmap instead of separate u32 flags allows a consistent, simpler
[]
> Use an enum ?

No strong preference.
If it's an enum .c file will change.

> Why first value is 1 and not 0 ?

Should be 0.

> > +#define TG3_FLAGS 74 /* Set to number of flags */
> Also you need to make TG3_FLAGS be (last_flag_value + 1) or you could
> miss one long in bitmap.

Right. Thanks for comments Eric.
I'll wait for Matt to comment before resubmitting.