public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] be2net: increment work_counter in be_worker
@ 2011-04-21 10:20 Ivan Vecera
  2011-04-22  0:36 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ivan Vecera @ 2011-04-21 10:20 UTC (permalink / raw)
  To: netdev; +Cc: sathya.perla, subbu.seetharaman, ajit.khaparde, davem

The commit 609ff3b adds support to display temperature of ASIC but there
is missing increment of work_counter in be_worker. Because of this 1) the
function be_cmd_get_die_temperature is called every 1 second instead of
every 32 seconds 2) be_cmd_get_die_temperature is called, although it is
not supported.
This patch fixes this bug.

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/benet/be_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 7cb5a11..02a0443 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -1873,6 +1873,7 @@ static void be_worker(struct work_struct *work)
 		be_detect_dump_ue(adapter);
 
 reschedule:
+	adapter->work_counter++;
 	schedule_delayed_work(&adapter->work, msecs_to_jiffies(1000));
 }
 
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] be2net: increment work_counter in be_worker
  2011-04-21 10:20 [PATCH] be2net: increment work_counter in be_worker Ivan Vecera
@ 2011-04-22  0:36 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-04-22  0:36 UTC (permalink / raw)
  To: ivecera; +Cc: netdev, sathya.perla, subbu.seetharaman, ajit.khaparde

From: Ivan Vecera <ivecera@redhat.com>
Date: Thu, 21 Apr 2011 12:20:04 +0200

> The commit 609ff3b adds support to display temperature of ASIC but there
> is missing increment of work_counter in be_worker. Because of this 1) the
> function be_cmd_get_die_temperature is called every 1 second instead of
> every 32 seconds 2) be_cmd_get_die_temperature is called, although it is
> not supported.
> This patch fixes this bug.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Applied to net-2.6, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-22  0:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21 10:20 [PATCH] be2net: increment work_counter in be_worker Ivan Vecera
2011-04-22  0:36 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox