From: "Michael Chan" <mchan@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap
Date: Thu, 21 Apr 2011 10:18:00 -0700 [thread overview]
Message-ID: <1303406280.8857.13.camel@HP1> (raw)
In-Reply-To: <02bf2aa5c08514641ecbe7c39ef976918fad036c.1303367730.git.joe@perches.com>
On Wed, 2011-04-20 at 23:39 -0700, Joe Perches wrote:
> @@ -4622,7 +4611,7 @@ static void tg3_tx_recover(struct tg3 *tp)
> "and include system chipset information.\n");
>
> spin_lock(&tp->lock);
> - tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING;
> + tg3_flag_set(tp, TX_RECOVERY_PENDING);
> spin_unlock(&tp->lock);
> }
>
By using set_bit() now, we can eliminate the spin_lock() here. This
flag is checked much later when tg3_reset_task() is scheduled to run in
workqueue, so no memory barrier is needed either.
Thanks.
next prev parent reply other threads:[~2011-04-21 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 17:57 [PATCH net-next 9/9] tg3: Add additional EEE messaging Matt Carlson
2011-04-21 6:39 ` [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap Joe Perches
2011-04-21 6:52 ` Joe Perches
2011-04-21 8:31 ` Eric Dumazet
2011-04-21 16:49 ` Joe Perches
2011-04-21 17:18 ` Michael Chan [this message]
2011-04-21 17:51 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2011-04-25 22:42 [PATCH net-next 0/6] tg3: TSO loopback and EEH support Matt Carlson
[not found] ` <1303776118.24299.1.camel@Joe-Laptop>
[not found] ` <20110426001738.GB802@mcarlson.broadcom.com>
[not found] ` <1303776574.24299.3.camel@Joe-Laptop>
[not found] ` <20110426013512.GA2031@mcarlson.broadcom.com>
2011-04-26 18:12 ` [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap Joe Perches
2011-04-26 19:49 ` David Miller
2011-04-27 16:28 ` Matt Carlson
2011-04-28 20:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303406280.8857.13.camel@HP1 \
--to=mchan@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).