From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v5] net: bnx2x: convert to hw_features Date: Fri, 22 Apr 2011 06:51:04 +0200 Message-ID: <1303447864.2784.26.camel@edumazet-laptop> References: <20110412144940.GA26043@rere.qmqm.pl> <20110411202630.C079D13909@rere.qmqm.pl> <1302610228.32697.298.camel@lb-tlvb-vladz> <20110412140708.GA21835@rere.qmqm.pl> <1302619012.6750.8.camel@lb-tlvb-vladz> <20110412193823.0823213A65@rere.qmqm.pl> <1303397531.3685.16.camel@edumazet-laptop> <20110421224134.GB7888@rere.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, Vladislav Zolotarov , Eilon Greenstein To: =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:50911 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514Ab1DVEvJ (ORCPT ); Fri, 22 Apr 2011 00:51:09 -0400 Received: by wya21 with SMTP id 21so238605wya.19 for ; Thu, 21 Apr 2011 21:51:08 -0700 (PDT) In-Reply-To: <20110421224134.GB7888@rere.qmqm.pl> Sender: netdev-owner@vger.kernel.org List-ID: Le vendredi 22 avril 2011 =C3=A0 00:41 +0200, Micha=C5=82 Miros=C5=82aw= a =C3=A9crit : > On Thu, Apr 21, 2011 at 04:52:11PM +0200, Eric Dumazet wrote: > > Le mardi 12 avril 2011 =C3=A0 21:38 +0200, Micha=C5=82 Miros=C5=82a= w a =C3=A9crit : > > > Since ndo_fix_features callback is postponing features change whe= n > > > bp->recovery_state !=3D BNX2X_RECOVERY_DONE, netdev_update_featur= es() > > > has to be called again when this condition changes. Previously, > > > ethtool_ops->set_flags callback returned -EBUSY in that case > > > (it's not possible in the new model). > > >=20 > > > Signed-off-by: Micha=C5=82 Miros=C5=82aw > > >=20 > > > v5: - don't delay set_features, as it's rtnl_locked - same as rec= overy process > > > v4: - complete bp->rx_csum -> NETIF_F_RXCSUM conversion > > > - add check for failed ndo_set_features in ndo_open callback > > > v3: - include NETIF_F_LRO in hw_features > > > - don't call netdev_update_features() if bnx2x_nic_load() fai= led > > > v2: - comment in ndo_fix_features callback > > > --- > > I am not sure its related to these changes, but I now have in > > net-next-2.6 : >=20 > > [ 23.674263] ------------[ cut here ]------------ > > [ 23.674266] WARNING: at net/core/dev.c:1318 dev_disable_lro+0x83= /0x90() > > [ 23.674270] Hardware name: ProLiant BL460c G6 > > [ 23.674273] Modules linked in: tg3 libphy sg > > [ 23.674280] Pid: 3070, comm: sysctl Tainted: G W 2.6.39= -rc2-01242-g3ef22b9-dirty #669 > > [ 23.674282] Call Trace: > > [ 23.674285] [] ? dev_disable_lro+0x83/0x90 > > [ 23.674291] [] warn_slowpath_common+0x8b/0xc0 > > [ 23.674298] [] warn_slowpath_null+0x15/0x20 > > [ 23.674304] [] dev_disable_lro+0x83/0x90 > > [ 23.674309] [] devinet_sysctl_forward+0x199/0= x210 > [...] >=20 > Hmm. Looks like something is not allowing to disable LRO. Please chec= k with > following patch so we can be sure which driver causes this. >=20 > Best Regards, > Micha=C5=82 Miros=C5=82aw Yes, obviously, and I suggested roughly the same patch some time ago.