netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
To: netfilter-devel@vger.kernel.org
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
	jengelh@medozas.de, davem@davemloft.net
Subject: [PATCH] netfilter/IPv6:  initialize TOS field in REJECT target module
Date: Fri, 22 Apr 2011 16:19:03 +0900	[thread overview]
Message-ID: <1303456743.2023.55.camel@nausicaa> (raw)
In-Reply-To: <1303455759.2023.39.camel@nausicaa>

The IPv6 header is not zeroed out in alloc_skb so we must initialize it
properly unless we want to see IPv6 packets with random TOS fields
floating around. The current implementation resets the flow label
but this could be changed if deemed necessary.

We stumbled upon this issue when trying to apply a mangle rule to
the RST packet generated by the REJECT target module.

Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
---

diff -urNp linux-2.6.38.4-orig/net/ipv6/netfilter/ip6t_REJECT.c linux-2.6.38.4/net/ipv6/netfilter/ip6t_REJECT.c
--- linux-2.6.38.4-orig/net/ipv6/netfilter/ip6t_REJECT.c	2011-03-15 10:20:32.000000000 +0900
+++ linux-2.6.38.4/net/ipv6/netfilter/ip6t_REJECT.c	2011-04-22 15:00:30.695373543 +0900
@@ -45,6 +45,8 @@ static void send_reset(struct net *net,
 	int tcphoff, needs_ack;
 	const struct ipv6hdr *oip6h = ipv6_hdr(oldskb);
 	struct ipv6hdr *ip6h;
+#define DEFAULT_TOS_VALUE	0x0U
+	const __u8 tclass = DEFAULT_TOS_VALUE;
 	struct dst_entry *dst = NULL;
 	u8 proto;
 	struct flowi fl;
@@ -123,7 +125,7 @@ static void send_reset(struct net *net,
 	skb_put(nskb, sizeof(struct ipv6hdr));
 	skb_reset_network_header(nskb);
 	ip6h = ipv6_hdr(nskb);
-	ip6h->version = 6;
+	*(__be32 *)ip6h =  htonl(0x60000000 | (tclass << 20));
 	ip6h->hop_limit = ip6_dst_hoplimit(dst);
 	ip6h->nexthdr = IPPROTO_TCP;
 	ipv6_addr_copy(&ip6h->saddr, &oip6h->daddr);



  parent reply	other threads:[~2011-04-22  7:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22  7:02 [PATCH] netfilter/IPv6: fix DSCP mangle code Fernando Luis Vazquez Cao
2011-04-22  7:08 ` David Miller
2011-04-22  7:29   ` Fernando Luis Vazquez Cao
2011-04-22  7:19 ` Fernando Luis Vazquez Cao [this message]
2011-04-22  7:34   ` [PATCH] netfilter/IPv6: initialize TOS field in REJECT target module Eric Dumazet
2011-04-22  7:47     ` Fernando Luis Vazquez Cao
2011-04-22  8:06       ` Eric Dumazet
2011-04-22  8:11         ` Fernando Luis Vazquez Cao
2011-04-22  8:37           ` Eric Dumazet
2011-04-26  1:13             ` Pablo Neira Ayuso
2011-04-26  1:26               ` Fernando Luis Vazquez Cao
2011-04-26  5:17                 ` David Miller
2011-04-26  5:25                   ` Fernando Luis Vazquez Cao
2011-04-26 15:34                     ` Pablo Neira Ayuso
2011-04-26 15:35                       ` Pablo Neira Ayuso
2011-04-27  4:21                         ` Fernando Luis Vazquez Cao
2011-05-06  8:27                       ` Fernando Luis Vázquez Cao
2011-05-06 10:38                         ` Pablo Neira Ayuso
2011-05-06 10:45                           ` Jan Engelhardt
2011-04-26  5:17               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303456743.2023.55.camel@nausicaa \
    --to=fernando@oss.ntt.co.jp \
    --cc=davem@davemloft.net \
    --cc=jengelh@medozas.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).