From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Rose, Gregory V" <gregory.v.rose@intel.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>
Subject: RE: [RFC PATCH] netlink: Increase netlink dump skb message size
Date: Tue, 26 Apr 2011 18:21:04 +0200 [thread overview]
Message-ID: <1303834864.3358.58.camel@edumazet-laptop> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755018DC497D4@orsmsx508.amr.corp.intel.com>
Le mardi 26 avril 2011 à 09:12 -0700, Rose, Gregory V a écrit :
> I'm fine with however you folks want to approach this, just give me some direction.
I would just try following patch :
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 4c4ac3f..22cac81 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -210,6 +210,7 @@ int netlink_sendskb(struct sock *sk, struct sk_buff *skb);
#else
#define NLMSG_GOODSIZE SKB_WITH_OVERHEAD(8192UL)
#endif
+#define NLMSG_DUMPSIZE SKB_WITH_OVERHEAD(8192UL)
#define NLMSG_DEFAULT_SIZE (NLMSG_GOODSIZE - NLMSG_HDRLEN)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index c8f35b5..cb8d6ac 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1669,7 +1669,7 @@ static int netlink_dump(struct sock *sk)
struct nlmsghdr *nlh;
int len, err = -ENOBUFS;
- skb = sock_rmalloc(sk, NLMSG_GOODSIZE, 0, GFP_KERNEL);
+ skb = sock_rmalloc(sk, NLMSG_DUMPSIZE, 0, GFP_KERNEL);
if (!skb)
goto errout;
next prev parent reply other threads:[~2011-04-26 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 22:01 [RFC PATCH] netlink: Increase netlink dump skb message size Greg Rose
2011-04-26 6:33 ` Eric Dumazet
2011-04-26 6:56 ` David Miller
2011-04-26 16:12 ` Rose, Gregory V
2011-04-26 16:21 ` Eric Dumazet [this message]
2011-04-26 16:24 ` Rose, Gregory V
2011-04-26 19:07 ` Ben Hutchings
2011-04-26 21:58 ` Rose, Gregory V
2011-04-27 15:46 ` Steve Hodgson
2011-04-27 16:30 ` Eric Dumazet
2011-04-27 17:15 ` Rose, Gregory V
2011-04-27 17:29 ` Eric Dumazet
2011-04-27 17:39 ` Rose, Gregory V
2011-04-27 18:05 ` Eric Dumazet
2011-04-27 18:08 ` Rose, Gregory V
2011-04-26 16:02 ` Rose, Gregory V
2011-04-29 19:29 ` David Miller
2011-04-29 19:37 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303834864.3358.58.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox