From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Tom Herbert <therbert@google.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] bql: Byte queue limits
Date: Tue, 26 Apr 2011 18:37:35 +0200 [thread overview]
Message-ID: <1303835855.3358.64.camel@edumazet-laptop> (raw)
In-Reply-To: <20110426091620.7c576a98@nehalam>
Le mardi 26 avril 2011 à 09:16 -0700, Stephen Hemminger a écrit :
> Although this is implemented as a device attribute, from a layering
> point of view it feels like a queuing strategy. Having two competing
> ways to do something is not always a good idea. Why is this not a
> qdisc parameter or a new qdisc?
>
The dequeue thing is performed in TX completion (one call for all
dequeued skbs to reduce overhead).
But its right the queueing test could be done generically (stop the
queue if limit reached).
BTW I did not check if both paths were SMP safe if run concurrently...
next prev parent reply other threads:[~2011-04-26 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 4:38 [PATCH 2/3] bql: Byte queue limits Tom Herbert
2011-04-26 5:38 ` Eric Dumazet
2011-04-26 14:13 ` Tom Herbert
2011-04-26 14:33 ` Eric Dumazet
2011-04-26 16:16 ` Stephen Hemminger
2011-04-26 16:37 ` Eric Dumazet [this message]
2011-04-28 12:53 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303835855.3358.64.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox