From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] ipv4: Sanitize and simplify ip_route_{connect,newports}()
Date: Wed, 27 Apr 2011 06:47:57 +0200 [thread overview]
Message-ID: <1303879677.2699.45.camel@edumazet-laptop> (raw)
In-Reply-To: <20110426.151202.245387083.davem@davemloft.net>
Le mardi 26 avril 2011 à 15:12 -0700, David Miller a écrit :
> These functions are used together as a unit for route resolution
> during connect(). They address the chicken-and-egg problem that
> exists when ports need to be allocated during connect() processing,
> yet such port allocations require addressing information from the
> routing code.
>
> It's currently more heavy handed than it needs to be, and in
> particular we allocate and initialize a flow object twice.
>
> Let the callers provide the on-stack flow object. That way we only
> need to initialize it once in the ip_route_connect() call.
>
> Later, if ip_route_newports() needs to do anything, it re-uses that
> flow object as-is except for the ports which it updates before the
> route re-lookup.
>
> Also, describe why this set of facilities are needed and how it works
> in a big comment.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Reviewed-by: Eric Dumazet <eric.dumazet@gmail.com>
prev parent reply other threads:[~2011-04-27 4:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 22:12 [PATCH 2/4] ipv4: Sanitize and simplify ip_route_{connect,newports}() David Miller
2011-04-27 4:47 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303879677.2699.45.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox