From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [ethtool PATCH 4/6] Add support for __be64 and bitops to ethtool Date: Wed, 27 Apr 2011 18:09:45 +0100 Message-ID: <1303924185.2875.48.camel@bwh-desktop> References: <20110421202857.23054.63316.stgit@gitlad.jf.intel.com> <20110421204035.23054.6918.stgit@gitlad.jf.intel.com> <1303919692.2875.11.camel@bwh-desktop> <4DB8484F.8030001@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "davem@davemloft.net" , "Kirsher, Jeffrey T" , "netdev@vger.kernel.org" To: Alexander Duyck Return-path: Received: from mail.solarflare.com ([216.237.3.220]:11769 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756284Ab1D0RJs (ORCPT ); Wed, 27 Apr 2011 13:09:48 -0400 In-Reply-To: <4DB8484F.8030001@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2011-04-27 at 09:46 -0700, Alexander Duyck wrote: > On 4/27/2011 8:54 AM, Ben Hutchings wrote: > > On Thu, 2011-04-21 at 13:40 -0700, Alexander Duyck wrote: > >> This change is meant to add support for __be64 values and bitops to > >> ethtool. These changes will be needed in order to support network flow > >> classifier rule configuration. [...] > > Where is __always_inline supposed to be defined? > > Sorry that should have just been inline. I forgot we have to take tools > other than gcc into account. Oh, it's a gcc extension? I read the code before trying to compile it. I've never tested with anything other than gcc but I think it's worth making a small effort to avoid gcc extensions. [...] > On a side note, is there a git tree somewhere I can re-base off of? At > this point I know you have pulled in a number of patches and I figure it > would be helpful for me to clean up my tree so I am not guessing what is > there and what isn't. git://git.kernel.org/pub/scm/network/ethtool/ethtool.git Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.