From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org,
Realtek linux nic maintainers <nic_swsd@realtek.com>
Subject: Re: [PATCH rfc 1/5] r8169: style cleanups.
Date: Wed, 27 Apr 2011 13:59:34 -0700 [thread overview]
Message-ID: <1303937974.24299.92.camel@Joe-Laptop> (raw)
In-Reply-To: <20110427203654.GD19708@electric-eye.fr.zoreil.com>
On Wed, 2011-04-27 at 22:36 +0200, Francois Romieu wrote:
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
[]
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
[]
> @@ -3134,8 +3128,8 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
[]
> - if (tp->mac_version == RTL_GIGA_MAC_VER_32 ||
> - tp->mac_version == RTL_GIGA_MAC_VER_33)
> + if ((tp->mac_version == RTL_GIGA_MAC_VER_32) ||
> + (tp->mac_version == RTL_GIGA_MAC_VER_33))
Shrug. I don't think this is better.
next prev parent reply other threads:[~2011-04-27 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 20:36 [PATCH rfc 1/5] r8169: style cleanups Francois Romieu
2011-04-27 20:59 ` Joe Perches [this message]
2011-04-27 21:00 ` David Miller
2011-05-04 19:17 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303937974.24299.92.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox