Re: [PATCH] bnx2: cancel timer on device removal

["Michael Chan" <mchan@broadcom.com>]

On Tue, 2011-04-26 at 13:30 -0700, Neil Horman wrote:
> Fix the problem by ensuring that the timer is stopped when
> pci_device_unregister
> is called.
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: Hushan Jia <hjia@redhat.com>
> CC: Michael Chan <mchan@broadcom.com>
> CC: "David S. Miller" <davem@davemloft.net>

Thanks Neil.

Acked-by: Michael Chan <mchan@broadcom.com>

> ---
>  drivers/net/bnx2.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index bf729ee..7f76d4c 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -8358,6 +8358,8 @@ bnx2_remove_one(struct pci_dev *pdev)
>  
>         unregister_netdev(dev);
>  
> +       del_timer_sync(&bp->timer);
> +
>         if (bp->mips_firmware)
>                 release_firmware(bp->mips_firmware);
>         if (bp->rv2p_firmware)