From: Joe Perches <joe@perches.com>
To: Mahesh Bandewar <maheshb@google.com>
Cc: "David Miller" <davem@davemloft.net>,
"Matt Carlson" <mcarlson@broadcom.com>,
netdev <netdev@vger.kernel.org>,
"Michael Chan" <mchan@broadcom.com>,
"Ben Hutchings" <bhutchings@solarflare.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCHv2 2/2] tg3: Add code to allow ethtool to enable/disable loopback.
Date: Sun, 01 May 2011 23:29:03 -0700 [thread overview]
Message-ID: <1304317743.7792.24.camel@Joe-Laptop> (raw)
In-Reply-To: <1304125404-19376-1-git-send-email-maheshb@google.com>
On Fri, 2011-04-29 at 18:03 -0700, Mahesh Bandewar wrote:
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
trivia:
> drivers/net/tg3.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++
[]
> @@ -15241,6 +15288,16 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
> dev->features |= hw_features;
> dev->vlan_features |= hw_features;
>
> + /*
> + * Add loopback capability only for a subset of devices that support
> + * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY
> + * loopback for the remaining devices.
> + */
> + if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 ||
> + !tg3_flag(tp, CPMU_PRESENT))
The indentation style is a bit out of character for the file.
Aligned to open parenthesis is the style used elsewhere:
if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 ||
!tg3_flag(tp, CPMU_PRESENT))
like this:
> if (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 &&
> !tg3_flag(tp, TSO_CAPABLE) &&
> !(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH)) {
prev parent reply other threads:[~2011-05-02 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 23:33 [PATCH 0/2] Loopback Mahesh Bandewar
2011-04-28 23:33 ` [PATCH 1/2] net: Allow ethtool to set interface in loopback mode Mahesh Bandewar
2011-04-28 23:33 ` [PATCH 2/2] tg3: Add code to allow ethtool to enable/disable loopback Mahesh Bandewar
2011-04-29 0:28 ` Matt Carlson
2011-04-29 1:42 ` Mahesh Bandewar
2011-04-29 2:46 ` Matt Carlson
2011-04-29 17:45 ` Mahesh Bandewar
2011-04-29 2:23 ` Matt Carlson
2011-04-30 1:03 ` [PATCHv2 " Mahesh Bandewar
2011-05-02 6:29 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304317743.7792.24.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox