netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mahesh Bandewar <maheshb@google.com>
To: Matt Carlson <mcarlson@broadcom.com>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	"Michael Chan" <mchan@broadcom.com>,
	"Ben Hutchings" <bhutchings@solarflare.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Tom Herbert" <therbert@google.com>,
	"Mahesh Bandewar" <maheshb@google.com>
Subject: [PATCH 1/2] net: Allow ethtool to set interface in loopback mode.
Date: Tue,  3 May 2011 18:18:54 -0700	[thread overview]
Message-ID: <1304471935-402-2-git-send-email-maheshb@google.com> (raw)
In-Reply-To: <1304471935-402-1-git-send-email-maheshb@google.com>

This patch enables ethtool to set the loopback mode on a given interface.
By configuring the interface in loopback mode in conjunction with a policy
route / rule, a userland application can stress the egress / ingress path
exposing the flows of the change in progress and potentially help developer(s)
understand the impact of those changes without even sending a packet out
on the network.

Following set of commands illustrates one such example -
    a) ip -4 addr add 192.168.1.1/24 dev eth1
    b) ip -4 rule add from all iif eth1 lookup 250
    c) ip -4 route add local 0/0 dev lo proto kernel scope host table 250
    d) arp -Ds 192.168.1.100 eth1
    e) arp -Ds 192.168.1.200 eth1
    f) sysctl -w net.ipv4.ip_nonlocal_bind=1
    g) sysctl -w net.ipv4.conf.all.accept_local=1
    # Assuming that the machine has 8 cores
    h) taskset 000f netserver -L 192.168.1.200
    i) taskset 00f0 netperf -t TCP_CRR -L 192.168.1.100 -H 192.168.1.200 -l 30

Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
 include/linux/netdevice.h |    3 ++-
 net/core/ethtool.c        |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index d5de66a..e7244ed 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1067,6 +1067,7 @@ struct net_device {
 #define NETIF_F_RXHASH		(1 << 28) /* Receive hashing offload */
 #define NETIF_F_RXCSUM		(1 << 29) /* Receive checksumming offload */
 #define NETIF_F_NOCACHE_COPY	(1 << 30) /* Use no-cache copyfromuser */
+#define NETIF_F_LOOPBACK	(1 << 31) /* Enable loopback */
 
 	/* Segmentation offload features */
 #define NETIF_F_GSO_SHIFT	16
@@ -1082,7 +1083,7 @@ struct net_device {
 	/* = all defined minus driver/device-class-related */
 #define NETIF_F_NEVER_CHANGE	(NETIF_F_VLAN_CHALLENGED | \
 				  NETIF_F_LLTX | NETIF_F_NETNS_LOCAL)
-#define NETIF_F_ETHTOOL_BITS	(0x7f3fffff & ~NETIF_F_NEVER_CHANGE)
+#define NETIF_F_ETHTOOL_BITS	(0xff3fffff & ~NETIF_F_NEVER_CHANGE)
 
 	/* List of features with software fallbacks. */
 #define NETIF_F_GSO_SOFTWARE	(NETIF_F_TSO | NETIF_F_TSO_ECN | \
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index d8b1a8d..f26649d 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -362,7 +362,7 @@ static const char netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
 	/* NETIF_F_RXHASH */          "rx-hashing",
 	/* NETIF_F_RXCSUM */          "rx-checksum",
 	/* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
-	"",
+	/* NETIF_F_LOOPBACK */        "loopback",
 };
 
 static int __ethtool_get_sset_count(struct net_device *dev, int sset)
-- 
1.7.3.1


  reply	other threads:[~2011-05-04  1:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04  1:18 [PATCHv3 0/2] Loopback Mahesh Bandewar
2011-05-04  1:18 ` Mahesh Bandewar [this message]
2011-05-04  1:18   ` [PATCHv3 2/2] tg3: Allow ethtool to enable/disable loopback Mahesh Bandewar
2011-05-04  1:52     ` Matt Carlson
2011-05-04 11:11     ` Michał Mirosław
2011-05-04 15:04       ` Stephen Hemminger
2011-05-04 16:05         ` Michał Mirosław
2011-05-04 16:08           ` Ben Hutchings
2011-05-05  1:34     ` [PATCHv4 " Mahesh Bandewar
2011-05-05  6:59       ` Michał Mirosław
2011-05-05 17:47         ` Mahesh Bandewar
2011-05-05 18:35           ` Michał Mirosław
2011-05-05 23:16             ` Mahesh Bandewar
2011-05-06  6:35               ` Michał Mirosław
2011-05-07  6:18       ` [PATCHv5 " Mahesh Bandewar
2011-05-07  7:43         ` Michał Mirosław
2011-05-08 16:50           ` Mahesh Bandewar
2011-05-08 16:51         ` [PATCHv6 " Mahesh Bandewar
2011-05-12 22:04           ` David Miller
2011-05-04 11:15   ` [PATCH 1/2] net: Allow ethtool to set interface in loopback mode Michał Mirosław
2011-05-05  1:30   ` [PATCHv2 " Mahesh Bandewar
2011-05-05  1:52     ` Ben Hutchings
2011-05-08 23:00       ` David Miller
2011-05-06  0:12     ` [PATCH net-next-2.6] sfc: Implement NETIF_F_LOOPBACK Ben Hutchings
2011-05-09  7:36       ` Michał Mirosław
2011-05-09 13:47         ` Ben Hutchings
  -- strict thread matches above, loose matches on Subject: below --
2011-04-28 23:33 [PATCH 0/2] Loopback Mahesh Bandewar
2011-04-28 23:33 ` [PATCH 1/2] net: Allow ethtool to set interface in loopback mode Mahesh Bandewar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304471935-402-2-git-send-email-maheshb@google.com \
    --to=maheshb@google.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=mcarlson@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).