From: Ben Hutchings <bhutchings@solarflare.com>
To: dmitry@broadcom.com
Cc: davem@davemloft.net,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eilon Greenstein <eilong@broadcom.com>,
Vladislav Zolotarov <vladz@broadcom.com>
Subject: Re: [net-next v2 1/6] bnx2x: link report improvements
Date: Wed, 04 May 2011 23:48:29 +0100 [thread overview]
Message-ID: <1304549309.2926.84.camel@bwh-desktop> (raw)
In-Reply-To: <1304547764.19742.17.camel@lb-tlvb-dmitry>
On Thu, 2011-05-05 at 01:22 +0300, Dmitry Kravkov wrote:
> From: Vladislav Zolotarov <vladz@broadcom.com>
>
> To avoid link notification duplication
[...]
> --- a/drivers/net/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/bnx2x/bnx2x_cmn.c
> @@ -758,35 +758,120 @@ u16 bnx2x_get_mf_speed(struct bnx2x *bp)
> return line_speed;
> }
>
> +/**
> + * bnx2x_fill_report_data - fill Link report data according to the current link
> + * configuration.
The kernel-doc format doesn't allow for continuation lines like this.
The short description has to fit on one physical line along with the
function or type name.
Ben.
> + * @bp: driver handle
> + * @data: link state to update
> + *
> + * It uses a none-atomic bit operations because is called under the mutex.
> + */
[...]
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-05-04 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 22:22 [net-next v2 1/6] bnx2x: link report improvements Dmitry Kravkov
2011-05-04 22:48 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304549309.2926.84.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).