From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Rafael Azenha Aquini <aquini@linux.com>,
kernel-janitors.vger.kernel.org@x61.tchesoft.com,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/bonding: bonding: Adjust coding style for bond_3ad files.
Date: Wed, 04 May 2011 16:49:53 -0700 [thread overview]
Message-ID: <1304552993.1788.135.camel@Joe-Laptop> (raw)
In-Reply-To: <20110504163803.57cde72e@nehalam>
On Wed, 2011-05-04 at 16:38 -0700, Stephen Hemminger wrote:
> On Wed, 4 May 2011 19:18:47 -0300
> Rafael Azenha Aquini <aquini@linux.com> wrote:
> > -// compare MAC addresses
> > #define MAC_ADDRESS_COMPARE(A, B) memcmp(A, B, ETH_ALEN)
> > static struct mac_addr null_mac_addr = { { 0, 0, 0, 0, 0, 0 } };
> These should be changed to use compare_ether_addr and is_zero_ether_addr
> routines in etherdevice.h
Hey Stephen.
null_mac_addr is used as a struct and should not be changed
to is_zero_ether_addr.
Maybe the uses could be changed to a memset, but I seem to
recall the code gets bigger.
drivers/net/bonding/bond_3ad.c:1637: aggregator->partner_system = null_mac_addr;
drivers/net/bonding/bond_3ad.c:1660: aggregator->aggregator_mac_address = null_mac_addr;
drivers/net/bonding/bond_3ad.c:1696: port->actor_system = null_mac_addr;
prev parent reply other threads:[~2011-05-04 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 22:18 [PATCH] net/bonding: bonding: Adjust coding style for bond_3ad files Rafael Azenha Aquini
2011-05-04 22:46 ` Joe Perches
2011-05-06 1:05 ` Rafael Aquini
2011-05-06 3:41 ` David Miller
2011-05-04 23:38 ` Stephen Hemminger
2011-05-04 23:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304552993.1788.135.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=andy@greyhouse.net \
--cc=aquini@linux.com \
--cc=fubar@us.ibm.com \
--cc=kernel-janitors.vger.kernel.org@x61.tchesoft.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).