From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] mlx4_en: Setting RSS hash result to skb->rxhash field
Date: Thu, 05 May 2011 08:55:18 +0200 [thread overview]
Message-ID: <1304578518.32152.794.camel@edumazet-laptop> (raw)
In-Reply-To: <953B660C027164448AE903364AC447D2070B8E35@mtldag01.mtl.com>
Le jeudi 05 mai 2011 à 06:47 +0000, Yevgeny Petrilin a écrit :
> >
> Eric, you are correct.
> We do plan to enable full 32 bit hash for our devices.
> Once it is done, we will naturally use the whole 32 bits.
> In the meanwhile, even with this change we see improved performance when enabling RPS.
Hmm, thats strange because you have only 256 possible values for rxhash,
and it's OK for maybe one hundred flows. (I am talking not of RPS but
RFS here)
So your patch is a win only for small hosts, or particular workloads
(did I say biased benchmarks ? ;) )
Really, we better use the linux/software full 32bit rxhash in this case,
and wait for your 32bit full support.
next prev parent reply other threads:[~2011-05-05 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 13:37 [PATCH] mlx4_en: Setting RSS hash result to skb->rxhash field Yevgeny Petrilin
2011-05-04 14:44 ` Ben Hutchings
2011-05-04 16:46 ` Eric Dumazet
2011-05-05 6:47 ` Yevgeny Petrilin
2011-05-05 6:55 ` Eric Dumazet [this message]
2011-05-05 6:57 ` Eric Dumazet
2011-05-05 7:08 ` Yevgeny Petrilin
2011-05-05 17:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304578518.32152.794.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox