From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Wei Yongjun" <weiyongjun1@huawei.com>
Cc: john.fastabend@gmail.com, toke@toke.dk, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/core: make function ___gnet_stats_copy_basic() static
Date: Wed, 26 Sep 2018 14:38:30 +0200 [thread overview]
Message-ID: <130487F6-D4E4-477E-9ED6-07DA541F263E@redhat.com> (raw)
In-Reply-To: <1537963785-165570-1-git-send-email-weiyongjun1@huawei.com>
On 26 Sep 2018, at 14:09, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> net/core/gen_stats.c:166:1: warning:
> symbol '___gnet_stats_copy_basic' was not declared. Should it be static?
>
Thanks for fixing my commit ;)
Acked-by: Eelco Chaudron <echaudro@redhat.com>
> Fixes: 5e111210a443 ("net/core: Add new basic hardware counter")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> net/core/gen_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
> index 65a2e82..9bf1b9a 100644
> --- a/net/core/gen_stats.c
> +++ b/net/core/gen_stats.c
> @@ -162,7 +162,7 @@
> }
> EXPORT_SYMBOL(__gnet_stats_copy_basic);
>
> -int
> +static int
> ___gnet_stats_copy_basic(const seqcount_t *running,
> struct gnet_dump *d,
> struct gnet_stats_basic_cpu __percpu *cpu,
next prev parent reply other threads:[~2018-09-26 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 12:09 [PATCH net-next] net/core: make function ___gnet_stats_copy_basic() static Wei Yongjun
2018-09-26 12:38 ` Eelco Chaudron [this message]
2018-09-26 17:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130487F6-D4E4-477E-9ED6-07DA541F263E@redhat.com \
--to=echaudro@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox