netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org,
	Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
Subject: [v2 058/115] sysctl: no-child: manually register fs/inotify
Date: Mon,  9 May 2011 00:39:10 +0200	[thread overview]
Message-ID: <1304894407-32201-59-git-send-email-lucian.grijincu@gmail.com> (raw)
In-Reply-To: <1304894407-32201-1-git-send-email-lucian.grijincu@gmail.com>

Signed-off-by: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
---
 fs/notify/inotify/inotify_user.c |   22 +++++++++++++++++++---
 include/linux/inotify.h          |    2 --
 kernel/sysctl.c                  |    7 -------
 3 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
index 8445fbc..ba618c2 100644
--- a/fs/notify/inotify/inotify_user.c
+++ b/fs/notify/inotify/inotify_user.c
@@ -51,13 +51,13 @@ static int inotify_max_user_watches __read_mostly;
 static struct kmem_cache *inotify_inode_mark_cachep __read_mostly;
 struct kmem_cache *event_priv_cachep __read_mostly;
 
-#ifdef CONFIG_SYSCTL
+#if defined(CONFIG_SYSCTL) && defined(CONFIG_MMU)
 
 #include <linux/sysctl.h>
 
 static int zero;
 
-ctl_table inotify_table[] = {
+static struct ctl_table inotify_table[] = {
 	{
 		.procname	= "max_user_instances",
 		.data		= &inotify_max_user_instances,
@@ -84,7 +84,22 @@ ctl_table inotify_table[] = {
 	},
 	{ }
 };
-#endif /* CONFIG_SYSCTL */
+static const __initdata struct ctl_path inotify_path[] = {
+	{ .procname = "fs" },
+	{ .procname = "inotify" },
+	{ }
+};
+static struct ctl_table_header *inotify_header;
+static int __init register_inotify_sysctls(void)
+{
+	inotify_header = register_sysctl_paths(inotify_path, inotify_table);
+	if (inotify_header == NULL)
+		return -ENOMEM;
+	return 0;
+}
+#else /* CONFIG_SYSCTL && CONFIG_MMU */
+static int __init register_inotify_sysctls(void) { return 0; }
+#endif /* CONFIG_SYSCTL && CONFIG_MMU */
 
 static inline __u32 inotify_arg_to_mask(u32 arg)
 {
@@ -862,6 +877,7 @@ static int __init inotify_user_setup(void)
 	inotify_max_user_instances = 128;
 	inotify_max_user_watches = 8192;
 
+	register_inotify_sysctls();
 	return 0;
 }
 module_init(inotify_user_setup);
diff --git a/include/linux/inotify.h b/include/linux/inotify.h
index d33041e..89b3bfe 100644
--- a/include/linux/inotify.h
+++ b/include/linux/inotify.h
@@ -71,8 +71,6 @@ struct inotify_event {
 #define IN_NONBLOCK O_NONBLOCK
 
 #ifdef __KERNEL__
-#include <linux/sysctl.h>
-extern struct ctl_table inotify_table[]; /* for sysctl */
 
 #define ALL_INOTIFY_BITS (IN_ACCESS | IN_MODIFY | IN_ATTRIB | IN_CLOSE_WRITE | \
 			  IN_CLOSE_NOWRITE | IN_OPEN | IN_MOVED_FROM | \
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 33d5e2e..9520e2b 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1439,13 +1439,6 @@ static struct ctl_table fs_table[] = {
 		.proc_handler	= proc_doulongvec_minmax,
 	},
 #endif /* CONFIG_AIO */
-#ifdef CONFIG_INOTIFY_USER
-	{
-		.procname	= "inotify",
-		.mode		= 0555,
-		.child		= inotify_table,
-	},
-#endif	
 #ifdef CONFIG_EPOLL
 	{
 		.procname	= "epoll",
-- 
1.7.5.134.g1c08b

  parent reply	other threads:[~2011-05-08 22:39 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-08 22:38 [v2 000/115] faster tree-based sysctl implementation Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 001/115] sysctl: remove .child from dev/parport/default Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 002/115] sysctl: parport: reorder .child assignments to simplify review Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 003/115] sysctl: remove .child from dev/parport/PORT/devices/DEVICE Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 004/115] sysctl: remove .child from dev/parport/PORT/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 005/115] sysctl: remove .child from dev/parport/PORT/devices/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 006/115] sysctl: remove .child from kernel/vsyscall64 (x86) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 007/115] sysctl: remove .child from abi/vsyscall32 (x86) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 008/115] sysctl: remove .child from crypto/fips_enabled Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 009/115] sysctl: remove .child from dev/cdrom/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 010/115] sysctl: remove .child from dev/hpet/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 011/115] sysctl: remove .child from dev/ipmi/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 012/115] sysctl: remove .child from dev/rtc/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 013/115] sysctl: remove .child from dev/mac_hid/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 014/115] sysctl: remove .child from dev/raid/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 015/115] sysctl: remove .child from xpc/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 016/115] sysctl: remove .child from xpc/hb Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 017/115] sysctl: remove .child from kernel/sclp (s390) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 018/115] sysctl: remove .child from dev/scsi Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 019/115] sysctl: remove .child from kernel/pty Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 020/115] sysctl: remove .child from coda/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 021/115] sysctl: remove .child from fscache/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 022/115] sysctl: remove .child from fs/nfs/ nlm_table table Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 023/115] sysctl: remove .child from fs/nfs/ nfs_cb_table Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 024/115] sysctl: remove .child from fs/ntfs-debug Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 025/115] sysctl: remove .child from fs/ocfs2/nm/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 026/115] sysctl: remove .child from fs/quota/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 027/115] sysctl: remove .child from fs/xfs/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 028/115] sysctl: remove .child from kernel/ (ipc) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 029/115] sysctl: remove .child from fs/mqueue Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 030/115] sysctl: sched: add sd_table_template Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 031/115] sysctl: remove .child from kernel/sched_domain/cpuX/domainY/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 032/115] sysctl: remove .child from kernel/ (utsname) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 033/115] sysctl: remove .child from sunrpc/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 034/115] sysctl: remove .child from sunrpc/svc_rdma Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 035/115] sysctl: remove .child from sunrpc/ (xprtrdma) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 036/115] sysctl: remove .child from sunrpc/ (xprtsock) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 037/115] sysctl: remove .child from bus/isa/ (arm) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 038/115] sysctl: remove .child from reboot/warm (arm) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 039/115] sysctl: remove .child from lasat/ (mips) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 040/115] sysctl: remove .child from appldata/ (s390) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 041/115] sysctl: remove .child from s390dbf/ Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 042/115] sysctl: remove .child from vm/ (s390) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 043/115] sysctl: remove .child from kernel/perfmon/ (ia64) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 044/115] sysctl: remove .child from kernel/ (ia64/kdump) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 045/115] sysctl: remove .child from kernel/powersave-nap (powerpc) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 046/115] sysctl: remove .child from pm/ (frv) Lucian Adrian Grijincu
2011-05-08 22:38 ` [v2 047/115] sysctl: remove .child from frv/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 048/115] sysctl: remove .child from sh64/unaligned_fixup/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 049/115] sysctl: delete unused register_sysctl_table function Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 050/115] sysctl: remove .child from ax25 table Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 051/115] sysctl: remove .child from net/ipv4/route and net/ipv4/neigh tables Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 052/115] sysctl: remove .child from net/ipv4/neigh table Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 053/115] sysctl: remove .child from net/ipv6/route, net/ipv6/icmp, net/ipv6 tables Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 054/115] sysctl: remove .child from net/llc tables Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 055/115] sysctl: call sysctl_init before the first sysctl registration Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 056/115] sysctl: no-child: manually register kernel/random Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 057/115] sysctl: no-child: manually register kernel/keys Lucian Adrian Grijincu
2011-05-08 22:39 ` Lucian Adrian Grijincu [this message]
2011-05-08 22:39 ` [v2 059/115] sysctl: no-child: manually register fs/epoll Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 060/115] sysctl: no-child: manually register root tables Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 061/115] sysctl: faster reimplementation of sysctl_check_table Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 062/115] sysctl: remove useless ctl_table->parent field Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 063/115] sysctl: simplify find_in_table Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 064/115] sysctl: sysctl_head_grab defaults to root header on NULL Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 065/115] sysctl: delete useless grab_header function Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 066/115] sysctl: rename ->used to ->ctl_use_refs Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 067/115] sysctl: rename sysctl_head_grab/finish to sysctl_use_header/unuse Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 068/115] sysctl: rename sysctl_head_next to sysctl_use_next_header Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 069/115] sysctl: split ->count into ctl_procfs_refs and ctl_header_refs Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 070/115] sysctl: rename sysctl_head_get/put to sysctl_proc_inode_get/put Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 071/115] sysctl: rename (un)use_table to __sysctl_(un)use_header Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 072/115] sysctl: simplify ->permissions hook Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 073/115] sysctl: group root-specific operations Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 074/115] sysctl: introduce ctl_table_group Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 075/115] sysctl: move removal from list out of start_unregistering Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 076/115] sysctl: faster tree-based sysctl implementation Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 077/115] sysctl: add duplicate entry and sanity ctl_table checks Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 078/115] sysctl: alloc ctl_table_header with kmem_cache Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 079/115] sysctl: single subheader path: optimisation for paths used only once Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 080/115] sysctl: single subheader path: net/ipv4/conf/DEVICE-NAME/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 081/115] sysctl: single subheader path: net/{ipv4|ipv6}/neigh/DEV/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 082/115] sysctl: single subheader path: net/ipv6/conf/DEVICE-NAME/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 083/115] sysctl: single subheader path: dev/parport/PORT/devices/DEVICE/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 084/115] sysctl: single subheader path: net/ax25/DEVICE Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 085/115] sysctl: single subheader path: kernel/sched_domain/CPU/DOMAIN/ Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 086/115] sysctl: single subheader path: net/decnet/conf/DEVNAME Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 087/115] sysctl: check netns-specific registration order respected Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 088/115] RFC: sysctl: convert read-write lock to RCU Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 089/115] RFC: sysctl: change type of ctl_procfs_refs to u8 Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 090/115] sysctl: warn if registration/unregistration order is not respected Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 091/115] sysctl: add register_sysctl_dir: register an empty sysctl directory Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 092/115] sysctl: sched: create empty dir with register_sysctl_dir Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 093/115] sysctl: ax25: " Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 094/115] sysctl: net/core: " Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 095/115] sysctl: net/ipv4/neigh: " Lucian Adrian Grijincu
2011-05-08 22:39 ` [v2 096/115] sysctl: net/ipv6/neigh: " Lucian Adrian Grijincu
2011-05-08 22:40 ` [v2 000/115] faster tree-based sysctl implementation David Miller
2011-05-09  3:11 ` Eric W. Biederman
2011-05-10  1:06   ` Lucian Adrian Grijincu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304894407-32201-59-git-send-email-lucian.grijincu@gmail.com \
    --to=lucian.grijincu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).