From: Ben Hutchings <bhutchings@solarflare.com>
To: Yaniv Rosner <yanivr@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
Yaniv Rosner <yaniv.rosner@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eilon Greenstein <eilong@broadcom.com>
Subject: Re: [PATCH net-next] ethtool: Add 20G bit definitions
Date: Mon, 09 May 2011 13:50:48 +0100 [thread overview]
Message-ID: <1304945448.4065.25.camel@localhost> (raw)
In-Reply-To: <1304936217.32472.10.camel@lb-tlvb-dmitry>
On Mon, 2011-05-09 at 13:16 +0300, Yaniv Rosner wrote:
> On Sun, 2011-05-08 at 15:43 -0700, David Miller wrote:
> > From: "Yaniv Rosner" <yanivr@broadcom.com>
> > Date: Tue, 3 May 2011 10:30:08 +0300
> >
> > > Add 20G supported and advertising bit definitions.
> > > 20G will be supported with the 57840 chips.
> > >
> > >
> > > Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> > > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> >
> > Applied to net-next-2.6, thanks.
> >
> Ben,
> Please note that I haven't added new definition for 20000 link speed
> because my understanding is that it no longer required.
> Let me know if you think it is required, mainly for the speed
> extension in the ethtool application.
There is no need (yet) for specific support of the speed. However you
should provide a patch for ethtool to make it report these flags in the
advertised/lp_advertised/supported masks.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-05-09 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 7:30 [PATCH net-next] ethtool: Add 20G bit definitions Yaniv Rosner
2011-05-08 22:43 ` David Miller
2011-05-09 10:16 ` Yaniv Rosner
2011-05-09 12:50 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304945448.4065.25.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yaniv.rosner@broadcom.com \
--cc=yanivr@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).