* [PATCH] net: group FCoE related feature flags
@ 2011-05-09 19:24 Yi Zou
[not found] ` <20110509192441.4502.77855.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Yi Zou @ 2011-05-09 19:24 UTC (permalink / raw)
To: netdev; +Cc: mirq-linux, jeffrey.t.kirsher, devel
Michał Mirosław's patch (http://patchwork.ozlabs.org/patch/94421/) fixes the
issue (http://patchwork.ozlabs.org/patch/94188/) about not populating FCoE related
flags correctly on vlan devices. However, only NETIF_F_FCOE_CRC is part of the
NETIF_F_ALL_TX_OFFLOADS right now, where weed NETIF_F_FCOE_MTU and NETIF_F_FSO
as well.
Therefore, add NETIF_F_ALL_FCOE to indicate feature flags used by FCoE TX offloads.
These include NETIF_F_FCOE_CRC, NETIF_F_FCOE_MTU, and NETIF_F_FSO. They are not part
of the NETIF_F_ALL_TX_OFFLOADS. This would eventually make sure all FCoE needed
flags are populated properly to vlan devices.
Signed-off-by: Yi Zou <yi.zou@intel.com>
---
include/linux/netdevice.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e7244ed..40b3df8 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1097,10 +1097,14 @@ struct net_device {
#define NETIF_F_ALL_TSO (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN)
+#define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \
+ NETIF_F_UFO)
+
#define NETIF_F_ALL_TX_OFFLOADS (NETIF_F_ALL_CSUM | NETIF_F_SG | \
NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \
NETIF_F_HIGHDMA | \
- NETIF_F_SCTP_CSUM | NETIF_F_FCOE_CRC)
+ NETIF_F_SCTP_CSUM | \
+ NETIF_F_ALL_FCOE)
/*
* If one device supports one of these features, then enable them
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20110509192441.4502.77855.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>]
* Re: [PATCH] net: group FCoE related feature flags [not found] ` <20110509192441.4502.77855.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org> @ 2011-05-09 20:17 ` Ben Hutchings 2011-05-09 21:15 ` Zou, Yi 0 siblings, 1 reply; 3+ messages in thread From: Ben Hutchings @ 2011-05-09 20:17 UTC (permalink / raw) To: Yi Zou Cc: netdev-u79uwXL29TY76Z2rM5mHXA, devel-s9riP+hp16TNLxjTenLetw, jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w, mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw On Mon, 2011-05-09 at 12:24 -0700, Yi Zou wrote: > Michał Mirosław's patch (http://patchwork.ozlabs.org/patch/94421/) fixes the > issue (http://patchwork.ozlabs.org/patch/94188/) about not populating FCoE related > flags correctly on vlan devices. However, only NETIF_F_FCOE_CRC is part of the > NETIF_F_ALL_TX_OFFLOADS right now, where weed NETIF_F_FCOE_MTU and NETIF_F_FSO > as well. > > Therefore, add NETIF_F_ALL_FCOE to indicate feature flags used by FCoE TX offloads. > These include NETIF_F_FCOE_CRC, NETIF_F_FCOE_MTU, and NETIF_F_FSO. They are not part > of the NETIF_F_ALL_TX_OFFLOADS. This would eventually make sure all FCoE needed > flags are populated properly to vlan devices. > > Signed-off-by: Yi Zou <yi.zou@intel.com> > --- > > include/linux/netdevice.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index e7244ed..40b3df8 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1097,10 +1097,14 @@ struct net_device { > > #define NETIF_F_ALL_TSO (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN) > > +#define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \ > + NETIF_F_UFO) UFO? Surely FSO, like you wrote in the commit message... Ben. > #define NETIF_F_ALL_TX_OFFLOADS (NETIF_F_ALL_CSUM | NETIF_F_SG | \ > NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \ > NETIF_F_HIGHDMA | \ > - NETIF_F_SCTP_CSUM | NETIF_F_FCOE_CRC) > + NETIF_F_SCTP_CSUM | \ > + NETIF_F_ALL_FCOE) > > /* > * If one device supports one of these features, then enable them > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. _______________________________________________ devel mailing list devel@open-fcoe.org https://lists.open-fcoe.org/mailman/listinfo/devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net: group FCoE related feature flags 2011-05-09 20:17 ` Ben Hutchings @ 2011-05-09 21:15 ` Zou, Yi 0 siblings, 0 replies; 3+ messages in thread From: Zou, Yi @ 2011-05-09 21:15 UTC (permalink / raw) To: Ben Hutchings Cc: netdev@vger.kernel.org, mirq-linux@rere.qmqm.pl, Kirsher, Jeffrey T, devel@open-fcoe.org > > On Mon, 2011-05-09 at 12:24 -0700, Yi Zou wrote: > > Michał Mirosław's patch (http://patchwork.ozlabs.org/patch/94421/) > fixes the > > issue (http://patchwork.ozlabs.org/patch/94188/) about not populating > FCoE related > > flags correctly on vlan devices. However, only NETIF_F_FCOE_CRC is part > of the > > NETIF_F_ALL_TX_OFFLOADS right now, where weed NETIF_F_FCOE_MTU and > NETIF_F_FSO > > as well. > > > > Therefore, add NETIF_F_ALL_FCOE to indicate feature flags used by FCoE > TX offloads. > > These include NETIF_F_FCOE_CRC, NETIF_F_FCOE_MTU, and NETIF_F_FSO. They > are not part > > of the NETIF_F_ALL_TX_OFFLOADS. This would eventually make sure all > FCoE needed > > flags are populated properly to vlan devices. > > > > Signed-off-by: Yi Zou <yi.zou@intel.com> > > --- > > > > include/linux/netdevice.h | 6 +++++- > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index e7244ed..40b3df8 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -1097,10 +1097,14 @@ struct net_device { > > > > #define NETIF_F_ALL_TSO (NETIF_F_TSO | NETIF_F_TSO6 | > NETIF_F_TSO_ECN) > > > > +#define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \ > > + NETIF_F_UFO) > > UFO? Surely FSO, like you wrote in the commit message... > > Ben. Yikes...how I missed that...thanks, will resend. yi > > > #define NETIF_F_ALL_TX_OFFLOADS (NETIF_F_ALL_CSUM | NETIF_F_SG | \ > > NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \ > > NETIF_F_HIGHDMA | \ > > - NETIF_F_SCTP_CSUM | NETIF_F_FCOE_CRC) > > + NETIF_F_SCTP_CSUM | \ > > + NETIF_F_ALL_FCOE) > > > > /* > > * If one device supports one of these features, then enable them > > > > -- > > To unsubscribe from this list: send the line "unsubscribe netdev" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Ben Hutchings, Senior Software Engineer, Solarflare > Not speaking for my employer; that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-09 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-09 19:24 [PATCH] net: group FCoE related feature flags Yi Zou
[not found] ` <20110509192441.4502.77855.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2011-05-09 20:17 ` Ben Hutchings
2011-05-09 21:15 ` Zou, Yi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).