From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Greg Rose <gregory.v.rose@intel.com>,
netdev@vger.kernel.org, bhutchings@solarflare.com,
davem@davemloft.net
Subject: Re: [RFC V2 PATCH] rtnetlink: Add method to calculate dump info data size
Date: Tue, 10 May 2011 06:03:02 +0200 [thread overview]
Message-ID: <1305000182.3050.50.camel@edumazet-laptop> (raw)
In-Reply-To: <20110509205626.19dede92@nehalam>
Le lundi 09 mai 2011 à 20:56 -0700, Stephen Hemminger a écrit :
> What happens is dump iterates over the table and puts entries into
> skb. When space is exhausted in skb the iterator stops and records the
> key of the where to restart.
Exactly : We would increase min_dump_alloc at this point, and not fully
recompute it at each round ;)
Problem is we could return an empty answer if first device ever dumped
in "ip link" would be a 'large one' and min_dump_alloc not yet
increased, so "ip link" would consider table is empty ?
Thats why I suggested to increase min_dump_alloc() when bloated^W driver
is loaded.
prev parent reply other threads:[~2011-05-10 4:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 22:26 [RFC V2 PATCH] rtnetlink: Add method to calculate dump info data size Greg Rose
2011-05-09 22:45 ` Stephen Hemminger
2011-05-09 22:49 ` Rose, Gregory V
2011-05-10 2:43 ` Eric Dumazet
2011-05-10 3:17 ` Stephen Hemminger
2011-05-10 3:45 ` Eric Dumazet
2011-05-10 3:49 ` David Miller
2011-05-10 4:25 ` Rose, Gregory V
2011-05-10 3:56 ` Stephen Hemminger
2011-05-10 3:58 ` David Miller
2011-05-10 4:03 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305000182.3050.50.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox