From: Joe Perches <joe@perches.com>
To: Rafael Aquini <aquini@linux.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
kernel-janitors@vger.kernel.org,
David Miller <davem@davemloft.net>,
Andy Gospodarek <andy@greyhouse.net>,
shemminger@vyatta.com, Nicolas Kaiser <nikai@nikai.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond_3ad files
Date: Wed, 11 May 2011 17:59:12 -0700 [thread overview]
Message-ID: <1305161952.19586.231.camel@Joe-Laptop> (raw)
In-Reply-To: <20110512001858.GA2435@x61.tchesoft.com>
On Wed, 2011-05-11 at 21:18 -0300, Rafael Aquini wrote:
> My bad, sorry. I'll be re-posting soon.
When you repost, it's considered useful and polite to have a
version # in the [PATCH net-next-2.6 v#] subject line
And add a changelog describing what's different in this version
below your sign-off is also good form.
The changelog doesn't get put into git history, but it's useful
for others to see what you've changed so reviewers can skip over
stuff that's been previously commented on and find the new stuff
easier.
Generally the email body contains
verbose patch description
Signed-off-by: you
Any Acks/Reviewed-bys: others
--- ( <- 3 dashes as a separator)
patch changelog if it exists
patch
cheers, Joe
next prev parent reply other threads:[~2011-05-12 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 22:52 [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond_3ad files Rafael Aquini
2011-05-11 23:52 ` Nicolas Kaiser
2011-05-12 0:18 ` Rafael Aquini
2011-05-12 0:59 ` Joe Perches [this message]
2011-05-12 0:28 ` Stephen Hemminger
2011-05-12 0:48 ` Rafael Aquini
-- strict thread matches above, loose matches on Subject: below --
2011-05-12 0:39 Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305161952.19586.231.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=andy@greyhouse.net \
--cc=aquini@linux.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).