From: Eric Dumazet <eric.dumazet@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Vitalii Demianets <vitas@nppfactor.kiev.ua>,
Ben Hutchings <bhutchings@solarflare.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH] bonding,llc: Fix structure sizeof incompatibility for some PDUs
Date: Thu, 12 May 2011 18:02:13 +0200 [thread overview]
Message-ID: <1305216133.3795.31.camel@edumazet-laptop> (raw)
In-Reply-To: <1305215554.6124.35.camel@Joe-Laptop>
Le jeudi 12 mai 2011 à 08:52 -0700, Joe Perches a écrit :
> On Thu, 2011-05-12 at 18:45 +0300, Vitalii Demianets wrote:
> > On Thursday 12 May 2011 17:33:36 Ben Hutchings wrote:
> > [...]
> > > The '__packed' macro is preferred.
> > Also, I'm slightly in doubt if I should split the patch in 2 parts, one for
> > bonding an one for LLC?
>
> What arch needs __packed for
>
> struct mac_addr {
> unsigned char addr[6];
> };
>
> ?
Believe it or not, they do exist. (ARM ...)
See "struct ethhdr" definition
Check commit 7cd636fe9ce5de0051c112 for another argument.
next prev parent reply other threads:[~2011-05-12 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 12:57 [PATCH] bonding,llc: Fix structure sizeof incompatibility for some PDUs Vitalii Demianets
2011-05-12 14:33 ` Ben Hutchings
2011-05-12 15:45 ` Vitalii Demianets
2011-05-12 15:52 ` Joe Perches
2011-05-12 16:02 ` Eric Dumazet [this message]
2011-05-12 16:10 ` Vitalii Demianets
2011-05-12 16:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305216133.3795.31.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=vitas@nppfactor.kiev.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox