From: Ben Hutchings <bhutchings@solarflare.com>
To: franco@lastsummer.de
Cc: netdev@vger.kernel.org, maheshb@google.com, mirqus@gmail.com
Subject: Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
Date: Thu, 12 May 2011 18:58:32 +0100 [thread overview]
Message-ID: <1305223112.5214.39.camel@bwh-desktop> (raw)
In-Reply-To: <20110512164204.EC8391220061@host64.kissl.de>
On Thu, 2011-05-12 at 18:42 +0200, franco@lastsummer.de wrote:
> The issue was introduced in commit eed2a12f1ed9aabf.
>
> Signed-off-by: Franco Fichtner <franco@lastsummer.de>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> net/core/ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index b6f4058..b8c2b10 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -361,7 +361,7 @@ static const char
> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
> /* NETIF_F_NTUPLE */ "rx-ntuple-filter",
> /* NETIF_F_RXHASH */ "rx-hashing",
> /* NETIF_F_RXCSUM */ "rx-checksum",
> - /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy"
> + /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy",
> /* NETIF_F_LOOPBACK */ "loopback",
> };
>
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-05-12 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 16:42 [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings franco
2011-05-12 16:45 ` Michał Mirosław
2011-05-12 17:59 ` Mahesh Bandewar
2011-05-12 21:50 ` David Miller
2011-05-12 17:58 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305223112.5214.39.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=franco@lastsummer.de \
--cc=maheshb@google.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).