* [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
@ 2011-05-12 16:42 franco
2011-05-12 16:45 ` Michał Mirosław
2011-05-12 17:58 ` Ben Hutchings
0 siblings, 2 replies; 5+ messages in thread
From: franco @ 2011-05-12 16:42 UTC (permalink / raw)
To: netdev; +Cc: maheshb, mirqus, franco
The issue was introduced in commit eed2a12f1ed9aabf.
Signed-off-by: Franco Fichtner <franco@lastsummer.de>
---
net/core/ethtool.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index b6f4058..b8c2b10 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -361,7 +361,7 @@ static const char
netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
/* NETIF_F_NTUPLE */ "rx-ntuple-filter",
/* NETIF_F_RXHASH */ "rx-hashing",
/* NETIF_F_RXCSUM */ "rx-checksum",
- /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy"
+ /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy",
/* NETIF_F_LOOPBACK */ "loopback",
};
--
1.7.3.2.493.g0b0cd
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
2011-05-12 16:42 [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings franco
@ 2011-05-12 16:45 ` Michał Mirosław
2011-05-12 17:59 ` Mahesh Bandewar
2011-05-12 21:50 ` David Miller
2011-05-12 17:58 ` Ben Hutchings
1 sibling, 2 replies; 5+ messages in thread
From: Michał Mirosław @ 2011-05-12 16:45 UTC (permalink / raw)
To: franco; +Cc: netdev, maheshb
2011/5/12 <franco@lastsummer.de>:
> The issue was introduced in commit eed2a12f1ed9aabf.
>
> Signed-off-by: Franco Fichtner <franco@lastsummer.de>
> ---
> net/core/ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index b6f4058..b8c2b10 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -361,7 +361,7 @@ static const char
> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
> /* NETIF_F_NTUPLE */ "rx-ntuple-filter",
> /* NETIF_F_RXHASH */ "rx-hashing",
> /* NETIF_F_RXCSUM */ "rx-checksum",
> - /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy"
> + /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy",
> /* NETIF_F_LOOPBACK */ "loopback",
> };
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
2011-05-12 16:42 [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings franco
2011-05-12 16:45 ` Michał Mirosław
@ 2011-05-12 17:58 ` Ben Hutchings
1 sibling, 0 replies; 5+ messages in thread
From: Ben Hutchings @ 2011-05-12 17:58 UTC (permalink / raw)
To: franco; +Cc: netdev, maheshb, mirqus
On Thu, 2011-05-12 at 18:42 +0200, franco@lastsummer.de wrote:
> The issue was introduced in commit eed2a12f1ed9aabf.
>
> Signed-off-by: Franco Fichtner <franco@lastsummer.de>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> net/core/ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index b6f4058..b8c2b10 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -361,7 +361,7 @@ static const char
> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
> /* NETIF_F_NTUPLE */ "rx-ntuple-filter",
> /* NETIF_F_RXHASH */ "rx-hashing",
> /* NETIF_F_RXCSUM */ "rx-checksum",
> - /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy"
> + /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy",
> /* NETIF_F_LOOPBACK */ "loopback",
> };
>
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
2011-05-12 16:45 ` Michał Mirosław
@ 2011-05-12 17:59 ` Mahesh Bandewar
2011-05-12 21:50 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Mahesh Bandewar @ 2011-05-12 17:59 UTC (permalink / raw)
To: Michał Mirosław; +Cc: franco, netdev
On Thu, May 12, 2011 at 9:45 AM, Michał Mirosław <mirqus@gmail.com> wrote:
> 2011/5/12 <franco@lastsummer.de>:
>> The issue was introduced in commit eed2a12f1ed9aabf.
>>
>> Signed-off-by: Franco Fichtner <franco@lastsummer.de>
>> ---
>> net/core/ethtool.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
>> index b6f4058..b8c2b10 100644
>> --- a/net/core/ethtool.c
>> +++ b/net/core/ethtool.c
>> @@ -361,7 +361,7 @@ static const char
>> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
>> /* NETIF_F_NTUPLE */ "rx-ntuple-filter",
>> /* NETIF_F_RXHASH */ "rx-hashing",
>> /* NETIF_F_RXCSUM */ "rx-checksum",
>> - /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy"
>> + /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy",
>> /* NETIF_F_LOOPBACK */ "loopback",
>> };
>
> Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
Acked-by: Mahesh Bandewar <maheshb@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings
2011-05-12 16:45 ` Michał Mirosław
2011-05-12 17:59 ` Mahesh Bandewar
@ 2011-05-12 21:50 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2011-05-12 21:50 UTC (permalink / raw)
To: mirqus; +Cc: franco, netdev, maheshb
From: Michał Mirosław <mirqus@gmail.com>
Date: Thu, 12 May 2011 18:45:12 +0200
> 2011/5/12 <franco@lastsummer.de>:
>> The issue was introduced in commit eed2a12f1ed9aabf.
>>
>> Signed-off-by: Franco Fichtner <franco@lastsummer.de>
>> ---
>> net/core/ethtool.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
>> index b6f4058..b8c2b10 100644
>> --- a/net/core/ethtool.c
>> +++ b/net/core/ethtool.c
>> @@ -361,7 +361,7 @@ static const char
>> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
>> /* NETIF_F_NTUPLE */ "rx-ntuple-filter",
>> /* NETIF_F_RXHASH */ "rx-hashing",
>> /* NETIF_F_RXCSUM */ "rx-checksum",
>> - /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy"
>> + /* NETIF_F_NOCACHE_COPY */ "tx-nocache-copy",
>> /* NETIF_F_LOOPBACK */ "loopback",
>> };
>
> Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Applied, but this patch was significantly mangled by your email
client. Please correct this problem before submitting future
patches, as I will just push them back to you if this happens
again.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-12 21:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-12 16:42 [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings franco
2011-05-12 16:45 ` Michał Mirosław
2011-05-12 17:59 ` Mahesh Bandewar
2011-05-12 21:50 ` David Miller
2011-05-12 17:58 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).