Re: [ethtool PATCH 0/4] v6 Add support for network flow classifier

[Ben Hutchings <bhutchings@solarflare.com>]

On Wed, 2011-05-04 at 11:41 -0700, Alexander Duyck wrote:
> This series is nearly identical to the last series with only a few changes in
> the RX packet classification interface patch.  Specifically I have narrowed
> down the rule manager to the point where it is only used to identify a
> location for a rule if the rule location is unspecified.  The display
> functionality for rules now just pulls the rule list in and goes through the
> list from top to bottom displaying the rules instead of initializing the rule
> manager and pulling the rules form there.
> 
> The main advantage to this approach is that the rule manager could easily be
> replaced by a future ioctl call and on the failure of that ioctl call with a
> return of EOPNOTSUPP it should be easy to fall back and just use the rule
> manager.

Thanks a lot for persevering with this, Alexander.

I've applied this series with minor changes to the last patch.  I
abbreviated the version history in the commit message, and I deleted a
blank line in the manual page additions which made the indentation wrong
for the -U option.  I also recorded the author as you, since you've
largely rewritten it!  The commit message credits Santwona Behera.

You managed to uncover a bug in the sfc driver, which is that
set_rx_ntuple can return a positive value.  Previously ethtool accepted
any non-negative return value as successful, so I made a separate commit
to restore that behaviour.  Of course I'll fix the driver too.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.